refactor: rename variable names for instances of ClaimsProvider

benefits/oauth/views.py

@@ -24,7 +24,7 @@
 TEMPLATE_SYSTEM_ERROR = "oauth/system_error.html"
 
 
-def _oauth_client_or_error_redirect(request, auth_provider):
+def _oauth_client_or_error_redirect(request, claims_provider):
     """Calls `benefits.oauth.client.create_client()`.
 
     If a client is created successfully, return it; Otherwise, return a redirect response to the `oauth:system-error` route.
@@ -34,12 +34,12 @@ def _oauth_client_or_error_redirect(request, auth_provider):
     exception = None
 
     try:
-        oauth_client = create_client(oauth, auth_provider)
+        oauth_client = create_client(oauth, claims_provider)
     except Exception as ex:
         exception = ex
 
     if not oauth_client and not exception:
-        exception = Exception(f"oauth_client not registered: {auth_provider.client_name}")
+        exception = Exception(f"oauth_client not registered: {claims_provider.client_name}")
 
     if exception:
         analytics.error(request, message=str(exception), operation="init")

tests/pytest/conftest.py

@@ -48,15 +48,15 @@ def model_PemData():
 
 @pytest.fixture
 def model_ClaimsProvider():
-    auth_provider = ClaimsProvider.objects.create(
+    claims_provider = ClaimsProvider.objects.create(
         sign_out_button_template="core/includes/button--sign-out--senior.html",
         sign_out_link_template="core/includes/link--sign-out--senior.html",
         client_name="Client",
         client_id_secret_name="1234",
         authority="https://example.com",
     )
 
-    return auth_provider
+    return claims_provider
 
 
 @pytest.fixture