Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE: [liqmaker] improve interval checking and tickers #1796

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Oct 28, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 316 BBG.

@c9s c9s enabled auto-merge October 28, 2024 09:34
ticker := time.NewTicker(interval.Duration())
defer ticker.Stop()

s.placeLiquidityOrders(ctx)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

place it twice?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes before the ticker

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we will need to wait for 1 hour

@c9s c9s merged commit 0c1f8f8 into main Oct 28, 2024
3 checks passed
@c9s c9s deleted the c9s/liqmaker/metrics-and-tests branch October 28, 2024 09:43
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 351 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x90f12395763d410eef696f271dddf3f327a59d0215a172f38f226db08e9443b1

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants