Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanups #20

Merged
merged 5 commits into from
Oct 4, 2023
Merged

More cleanups #20

merged 5 commits into from
Oct 4, 2023

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Oct 4, 2023 •
edited
Loading

@ineiti ineiti marked this pull request as draft October 4, 2023 09:22
@ineiti ineiti self-assigned this Oct 4, 2023
@ineiti ineiti mentioned this pull request Oct 4, 2023
Closed
@ineiti ineiti force-pushed the more_cleanups branch 2 times, most recently from 7ac843e to 17c9a85 Compare October 4, 2023 10:56
@ineiti ineiti marked this pull request as ready for review October 4, 2023 10:57
@ineiti ineiti requested a review from PascalinDe October 4, 2023 13:52
@ineiti
Nicefying vote comments
86c7c5e 
@PascalinDe's comments
@ineiti
@pierluca's comments
61d7ac9 
- check doesn't work
- use variable for randomizing vote ID
@ineiti ineiti merged commit 6149677 into main Oct 4, 2023
9 of 10 checks passed
@ineiti ineiti deleted the more_cleanups branch October 4, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalinDe PascalinDe PascalinDe approved these changes

@lanterno lanterno Awaiting requested review from lanterno

Assignees

@ineiti ineiti

Labels
None yet
Projects
D-Voting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ineiti @PascalinDe