Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all go version in the tests on 1.20 #116

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix all go version in the tests on 1.20 #116

merged 1 commit into from
Feb 15, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Feb 15, 2024

There is a regression error in go 1.22.
This PR fixes the go version to 1.20.x:

  • updated go.mod
  • updated github workflows
  • removed rand.Seed from integration tests (which was useless anyway, because of non-deterministic go-routines)

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Feb 15, 2024
@ineiti ineiti force-pushed the fix_go_version branch 7 times, most recently from 7689748 to ae7a554 Compare February 15, 2024 08:50
There is a regression error in go 1.22.
As the go.mod fixes the go version at 1.19, all github workflow now
use go 1.19.
@ineiti ineiti marked this pull request as ready for review February 15, 2024 08:58
@ineiti ineiti changed the title Fix all go version in the tests on 1.19 Fix all go version in the tests on 1.20 Feb 15, 2024
@ineiti ineiti mentioned this pull request Feb 15, 2024
7 tasks
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why was the seed fixed in the first place?

@ineiti
Copy link
Member Author

ineiti commented Feb 15, 2024

They wanted to have deterministic tests. So anything depending on randomness would give the same result on every run.

But if the go-routines are not deterministic (and they aren't), and if the go-routines take data from the random-number generator, the outcome is not deterministic anymore. Or at least most of the time. Unless you use Antithesis :)

@ineiti ineiti merged commit f0fabf1 into main Feb 15, 2024
12 checks passed
@ineiti ineiti deleted the fix_go_version branch February 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants