Winch aarch64 dynamic heap #9252
Conversation
Subscribe to Label Action
This issue or pull request has been labeled: "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
| fn cmov(&mut self, src: Reg, dst: Reg, cc: IntCmpKind, size: OperandSize) { | ||
| self.asm.jmp_if_resolved(Cond::from(cc).invert(), 12); | ||
| self.asm.mov_rr(src, dst, size) |
There was a problem hiding this comment.
I think it'd be better to handle this instruction via csel. Any particular reason you decided to go this route?
There was a problem hiding this comment.
You're right, I didn't think about it
| todo!() | ||
| fn checked_uadd(&mut self, dst: Reg, lhs: Reg, rhs: RegImm, size: OperandSize, trap: TrapCode) { | ||
| self.add(dst, lhs, rhs, size); | ||
| self.asm.trapif(Cond::Vs, trap); |
There was a problem hiding this comment.
I believe here we'd want to use Cond::Hs? The Cond::Vs is for signed overflow. (Ref: https://developer.arm.com/documentation/dui0801/l/Condition-Codes/Carry-flag)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@vulc41n it looks like an update to the filetests is needed? |
saulecabrera
force-pushed
the
winch-aarch64-dyn-heap
branch
from
7eab647
to
1385776
Compare
|
@vulc41n filetests were correct, it needed a rebase. I took the liberty to do the rebase so that we can go ahead and land this PR. |
Hey 👋
This PR implements everything needed to run winch for aarch64 with dynamic heap. It implements the following macro instructions :
trap,trapif,cmovandchecked_add.