28 generating mipmaps #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-russo
force-pushed
the
28_generating_mipmaps
branch
from
a4a3802
to
bffe098
Compare
…. Cannot figure out how to properly query for depth formats
matthew-russo
force-pushed
the
28_generating_mipmaps
branch
from
bffe098
to
09d2681
Compare
matthew-russo
force-pushed
the
28_generating_mipmaps
branch
from
09d2681
to
5fc4830
Compare
|
I'm new to rust but it seems that the from_buffer method of the ImmutableImage have an implementation of mipmaps - could this be used? https://github.com/vulkano-rs/vulkano/blob/v0.21.0/vulkano/src/image/immutable.rs#L351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the README there are some Validation Layer issues with this but I dont have any solutions. This issue describes the same thing at the end: vulkano-rs/vulkano#989. Essentially when blitting and the destination and source are the same, the image layout is properly transitioned.
I was experimenting with UnsafeCommandBufferBuilder and manually creating the memory barriers and image transitions but ran into a lot of issues because I also then needed to manually synchronize and submit everything, bypassing all of the nice abstractions that Vulkano has provided and I didn't include any of that. It didn't seem worth it as its not the point of Vulkano and if I'm going to be rewriting/implementing some of these core building blocks I'd rather just spend the time working on Vulkano itself itself and get it to a point where we can idiomatically handle cases like this. I linked to Ash and their version of this tutorial so users can see what a more direct 1-1 translation of this would look like in Rust.
Let me know any feedback on this, whether you think we should figure out our own abstraction on the lower level building blocks, etc. etc. And as with the other PRs, I haven't tested on mac yet. I'm planning on getting the last section, multisampling, in and then giving it a full test sweep on Windows and Mac (and maybe a few linux flavors if I'm motivated). I started running everything through Clippy and only some internal macro stuff is getting tagged.