-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group8 - BSCS17063 - Updated Form.php (8-13, 20-30, 51-80 and 90-91) All Issues Resolved #2570
Open
Ch-Usman-266
wants to merge
7
commits into
burhanrasool:main
Choose a base branch
from
Ch-Usman-266:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 269: More than 80 characters in a line $temp was created to split character in multiple lines to resoved this issue. Line 270: More than 80 characters in a line $temp and $vartemp was created to split character in multiple lines to resoved this issue. Line 271: More than 80 characters in a line $temp and $vartemp was created to split character in multiple lines to resoved this issue. Line 272: More than 80 characters in a line $temp and $vartemp was created to split character in multiple lines to resoved this issue. Line273: More than 80 characters in a line $temp and $vartemp was created to split character in multiple lines to resoved this issue. line 274 : More than 80 characters in a line $temp and $vartemp was created to split character in multiple lines to resoved this issue.
Issue Number: 8 Line Number: 649 Filename: Controller/form.php Resolution: 2 new variables tmp_arg and tmp_arg2 created and white spaces were removed to keep line within the 80-character per line limit Issue Number: 9 Line Number: 656 Filename: Controller/form.php Resolution: temp_var created to split line and keep it within 80-character per line limit Issue Number: 10 Line Number: 660 Filename: Controller/form.php Resolution: temp_choice created to split line and keep it within 80-character per line limit Issue Number: 11 Line Number: 670 Filename: Controller/form.php Resolution: temp_choice created and white spaces deleted to split line and keep it within the 80-character per line limit Issue Number: 12 Line Number: 682 Filename: Controller/form.php Resolution: temp_arg and temp_var to split line and keep it within the 80-character per line limit Issue Number: 13 Line Number: 699 Filename: Controller/form.php Resolution: temp_var, temp_var_2 and temp_var_3 created split line and keep it within the 80-character per line limit
This reverts commit bf470b4.
Issue Number: 20 Line Number: 754 Filename: Controller/form.php Resolution: temp_arg and temp_var created to split the line and keep it within the 80-character per line limit Issue Number: 21 Line Number: 759 Filename: Controller/form.php Resolution: temp_arg and temp_var created to split the line and keep it within the 80-character per line limit Issue Number: 22 Line Number:759 Filename: Controller/form.php Resolution: temp_arg and temp_var created to split the line and keep it within the 80-character per line limit Issue Number: 23 Line Number: 774 Filename: Controller/form.php Resolution: Newlines inserted, and same function call is now split into multiple lines. Issue Number: 24 Line Number:782 Filename: Controller/form.php Resolution: temp_arg created to separate function arguments in multiple lines to split the line and keep it within the 80-character per line limit; Issue Number: 25 Line Number:783 Filename: Controller/form.php Resolution: temp_arg and temp_argv2 created to separate function arguments in multiple lines to split the line and keep it within the 80-character per line limit; Issue Number: 26 Line Number:785 Filename: Controller/form.php Resolution: temp_arg, temp_var created and newlines inserted, and same function call is now split into multiple lines. Issue Number: 27 Line Number:802 Filename: Controller/form.php Resolution: temp_var created to split the line and keep it within the 80-character per line limit Issue Number: 28 Line Number:819 Filename: Controller/form.php Resolution: temp_var created and newlines inserted in between function arguments to split the function arguments in multiple lines and keep the line within the 80-character per line limit Issue Number: 29 Line Number:825 Filename: Controller/form.php Resolution: temp_var created split the line into in multiple lines and keep the line within the 80-character per line limit Issue Number: 30 Line Number:829 Filename: Controller/form.php Resolution: temp_var created split the line into in multiple lines and keep the line within the 80-character per line limit
Ch-Usman-266
changed the title
Group8 - BSCS17063 - Updated Form.php (8-13 Issue resolved)
Group8 - BSCS17063 - Updated Form.php (More then 80 character per line resolved)
Jan 19, 2021
Issue Number 51 Line (995 of original document) (1030 of this document): temp_var created to split the line reformat code according to PITB (80-character per line limit) standards. Issue Number 52 Line (997 of original document) (1032 of this document): temp_arg created to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 53 Line (1043 of original document) (1078 of this document): Newline inserted in between arguments of function to split the line reformat code according to PITB (80-character per line limit) standards. Issue Number 54 Line (1044 of original document) (1079 of this document): temp_var created to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 55 Line (1084 of original document) (1119 of this document): temp_arg created and newline inserted in between arguments of function to split the line and reformat code code according to PITB (80-character per line limit) standards. Issue Number 56 Line (1085 of original document) (1120 of this document): temp_arg created to to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 57 Line (1092 of original document) (1127 of this document): new line inserted in between arguments of if condition split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 58 Line (1104 of original document) (1139 of this document): new line inserted in between arguments of if condition split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 59 Line (1127 of original document) (1162 of this document): new line inserted in between comment to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 60 Line (1137 of original document) (1172 of this document): new line inserted in between arguments of function call to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 61 Line (1145 of original document) (1180 of this document): new line inserted in between arguments of function call to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 62 Line (1152 of original document) (1187 of this document): new line inserted in between arguments of function call to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 63 Line (1158 of original document) (1193 of this document): new line inserted in between arguments of function call to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 64 Line (1201 of original document) (1236 of this document): new line inserted in between arguments of function call to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 65 Line (1204 of original document) (1239 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 66 Line (1210 of original document) (1245 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 67 Line (1225 of original document) (1260 of this document): temp_var created to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 68 Line (1259 of original document) (1294 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 69 Line (1270 of original document) (1305 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 70 Line (1272 of original document) (1307 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 71 Line (1279 of original document) (1314 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 72 Line (1295 of original document) (1330 of this document): temp_arg created and new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 73 Line (1309 of original document) (1344 of this document): new line inserted in between arguments of if condition to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 74 Line (1323 of original document) (1357 of this document): line is exactly 80 characters Issue Number 75 Line (1327 of original document) (1362 of this document): new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 76 Line (1330 of original document) (1365 of this document): new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 77 Line (1345 of original document) (1380 of this document): new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 78 Line (1358 of original document) (1393 of this document): temp_var created and new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 79 Line (1365 of original document) (1400 of this document): new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards. Issue Number 80 Line (1369 of original document) (1404 of this document): new line inserted in between arguments of function to split the line and reformat code according to PITB (80-character per line limit) standards.
Line burhanrasool#40 variable name changed to lower_snake_case Line#43 variable reference also changed to the correct name
…ted - Apimaker.php Line 85# variable existArray named chaged to lower_snake_case
Ch-Usman-266
changed the title
Group8 - BSCS17063 - Updated Form.php (More then 80 character per line resolved)
Group8 - BSCS17063 - Updated Form.php (8-13, 20-30, 51-80 and 90-91) All Issues Resolved
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.php was wrongly updated yesterday, changes have been reverted. Correct changes have been now updated in form.php .
Issue Number: 8
Line Number: 649
Filename: Controller/form.php
Resolution: 2 new variables tmp_arg and tmp_arg2 created and white spaces were removed to keep line within the 80-character per line limit
Issue Number: 9
Line Number: 656
Filename: Controller/form.php
Resolution: temp_var created to split line and keep it within 80-character per line limit
Issue Number: 10
Line Number: 660
Filename: Controller/form.php
Resolution: temp_choice created to split line and keep it within 80-character per line limit
Issue Number: 11
Line Number: 670
Filename: Controller/form.php
Resolution: temp_choice created and white spaces deleted to split line and keep it within the 80-character per line limit
Issue Number: 12
Line Number: 682
Filename: Controller/form.php
Resolution: temp_arg and temp_var to split line and keep it within the 80-character per line limit
Issue Number: 13
Line Number: 699
Filename: Controller/form.php
Resolution: temp_var, temp_var_2 and temp_var_3 created split line and keep it within the 80-character per line limit