Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the Glide Class to Improve Cyclomatic Complexity #5420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactoring the Glide Class to Improve Cyclomatic Complexity #5420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 21 additions & 37 deletions library/src/main/java/com/bumptech/glide/Glide.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,23 @@ public static File getPhotoCacheDir(@NonNull Context context) {
@Nullable
public static File getPhotoCacheDir(@NonNull Context context, @NonNull String cacheName) {
File cacheDir = context.getCacheDir();
if (cacheDir != null) {
File result = new File(cacheDir, cacheName);
if (result.isDirectory() || result.mkdirs()) {
return result;
}
// File wasn't able to create a directory, or the result exists but not a directory
if (cacheDir == null) {
Log.e(TAG, "getCacheDir returned null");
return null;
}
if (Log.isLoggable(TAG, Log.ERROR)) {
Log.e(TAG, "default disk cache dir is null");

File result = new File(cacheDir, cacheName);
if (result.mkdirs()) {
return result;
} else {
if (Log.isLoggable(TAG, Log.WARN)) {
Log.w(TAG, "Failed to create directory: " + result);
}
return null;
}
return null;
}


/**
* Get the singleton.
*
Expand Down Expand Up @@ -224,45 +227,26 @@ private static void initializeGlide(
@NonNull Context context,
@NonNull GlideBuilder builder,
@Nullable GeneratedAppGlideModule annotationGeneratedModule) {

Context applicationContext = context.getApplicationContext();

List<GlideModule> manifestModules = Collections.emptyList();
if (annotationGeneratedModule == null || annotationGeneratedModule.isManifestParsingEnabled()) {
manifestModules = new ManifestParser(applicationContext).parse();
}

if (annotationGeneratedModule != null
&& !annotationGeneratedModule.getExcludedModuleClasses().isEmpty()) {
Set<Class<?>> excludedModuleClasses = annotationGeneratedModule.getExcludedModuleClasses();
Iterator<GlideModule> iterator = manifestModules.iterator();
while (iterator.hasNext()) {
GlideModule current = iterator.next();
if (!excludedModuleClasses.contains(current.getClass())) {
continue;
}
if (Log.isLoggable(TAG, Log.DEBUG)) {
Log.d(TAG, "AppGlideModule excludes manifest GlideModule: " + current);
}
iterator.remove();
}
}

if (Log.isLoggable(TAG, Log.DEBUG)) {
for (GlideModule glideModule : manifestModules) {
Log.d(TAG, "Discovered GlideModule from manifest: " + glideModule.getClass());
}
}
Set<Class<?>> excludedModules = annotationGeneratedModule != null ? annotationGeneratedModule.getExcludedModuleClasses() : Collections.emptySet();
manifestModules = manifestModules.stream()
.filter(module -> !excludedModules.contains(module.getClass()))
.collect(Collectors.toList());

RequestManagerRetriever.RequestManagerFactory factory =
annotationGeneratedModule != null
? annotationGeneratedModule.getRequestManagerFactory()
: null;
RequestManagerRetriever.RequestManagerFactory factory = annotationGeneratedModule != null ? annotationGeneratedModule.getRequestManagerFactory() : null;
builder.setRequestManagerFactory(factory);
for (GlideModule module : manifestModules) {
module.applyOptions(applicationContext, builder);
}
manifestModules.forEach(module -> module.applyOptions(applicationContext, builder));
if (annotationGeneratedModule != null) {
annotationGeneratedModule.applyOptions(applicationContext, builder);
}

Glide glide = builder.build(applicationContext, manifestModules, annotationGeneratedModule);
applicationContext.registerComponentCallbacks(glide);
Glide.glide = glide;
Expand Down