Fix broken DownsamplerEmulatorTest due to class-not-found regression #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanelbulle
reviewed
Feb 2, 2024
...on/src/androidTest/java/com/bumptech/glide/load/resource/bitmap/DownsamplerEmulatorTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to DownsamplerSamplerEmulatorTest in #5357 broke the test, with errors loading the SDK level 34 class, android.graphics.Gainmap:
"Caused by: java.lang.ClassNotFoundException: Didn't find class "android.graphics.Gainmap" on path"
Apparently, the test runner does a class resolution of all method signatures, even if they have a @RequiresApi annoation. This will fail on emulators that have SDK levels that don't include the class. Also, even import statements seem to fail.
I basically inlined the method, which is version-guarded, and removed the explicit import.