Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick request FullAccess on iOS17+ (#497) #519

Merged

Conversation

LeonardoCaracho
Copy link

Cherry-pick referencing this issue.

* fix: request FullAccess on iOS17 or later

* update iOS integration description

* fix: iOS build test & Android build test
@LeonardoCaracho LeonardoCaracho marked this pull request as ready for review December 13, 2023 18:48
@LuizFritsch
Copy link

Hello, I'm looking forward to having this PR merged and the plugin working :)
Do you know by any chance when you will be able to review this PR @thomassth?

@istornz
Copy link

istornz commented Feb 27, 2024

Any news about merging this mandatory fix for iOS 17+?
Thanks :)

@IVLIVS-III
Copy link
Contributor

@LeonardoCaracho thanks for creating this PR. Sorry for not looking at this sooner.
Please also change the version in pubspec.yaml and add a new entry in the CHANGELOG.md.
Then I can merge this PR to get the fix published. Without the version change, we cannot publish to pub.dev.

@LeonardoCaracho
Copy link
Author

@LeonardoCaracho thanks for creating this PR. Sorry for not looking at this sooner. Please also change the version in pubspec.yaml and add a new entry in the CHANGELOG.md. Then I can merge this PR to get the fix published. Without the version change, we cannot publish to pub.dev.

Done! thanks for the reply ;)

IVLIVS-III
IVLIVS-III previously approved these changes Feb 28, 2024
@istornz
Copy link

istornz commented Feb 28, 2024

@LeonardoCaracho I think you will need to change file device_calendar/example/lib/presentation/pages/calendar_event.dart line 867.
This is why the CI failed.

Change with:

style: ElevatedButton.styleFrom(
  foregroundColor: Colors.white,
  backgroundColor: Colors.red),
)

@IVLIVS-III
Copy link
Contributor

Bildschirmfoto 2024-02-28 um 17 51 09

I'm afraid, my write access is not sufficient to merge this PR… the master branch has some extra protection.
We will need @thomassth to do the merge.

@thomassth thomassth merged commit bc7bccb into builttoroam:master Feb 28, 2024
4 checks passed
@thomassth
Copy link
Contributor

Release pipeline doesn't work (again)

While I got the permission to renew the pub key, GitHub cred access is still locked from me

Paging @nickrandolph

@istornz
Copy link

istornz commented Feb 29, 2024

Thanks guys for your speed!

@fourthperson
Copy link

fourthperson commented Mar 8, 2024

Hello guys, @thomassth and @IVLIVS-III , you forgot to add the new recommended namespace value in the android block to support Gradle 8.0 and consequently, newer android versions.

https://developer.android.com/build/configure-app-module#set-namespace

it is supposed to go into the

android {
namespace: 'your-namespace-here'
}

block of your module/build.gradle file.

Update:
I can see it in your build.gradle file, on the master branch, but when I pull mine from git, I seem not to have it declared.

Here is my pubspec.yaml section of device_calendar.

device_calendar: #^4.3.2
    git:
      url: https://github.com/builttoroam/device_calendar.git
      ref: master

Is there anything I am doing wrong? Kindly assist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants