Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included namespace for Android Gradle Plugin Version 8.0+ and Gradle Version 8.0 #508

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ash80
Copy link

@ash80 ash80 commented Oct 10, 2023

No description provided.

@IVLIVS-III
Copy link
Contributor

Hi @ash80 thanks for this PR. Can you please elaborate why we should include the namespace. Does this fix an issue? Is it good practice? Any other reason?

@ash80 ash80 changed the title Included namespace Included namespace for Android Gradle Plugin Version 8.1.1+ and Gradle Version 8.0 Oct 10, 2023
@ash80
Copy link
Author

ash80 commented Oct 10, 2023

Hi @ash80 thanks for this PR. Can you please elaborate why we should include the namespace. Does this fix an issue? Is it good practice? Any other reason?

I have changed the title now. namespace is required for Android Gradle Plugin version ^8.1.1 and Gradle Version ^8.0. Take a look at the following issue for example:
MisterJimson/flutter_keyboard_visibility#141

@ash80 ash80 changed the title Included namespace for Android Gradle Plugin Version 8.1.1+ and Gradle Version 8.0 Included namespace for Android Gradle Plugin Version 8.0+ and Gradle Version 8.0 Oct 10, 2023
Copy link
Contributor

@IVLIVS-III IVLIVS-III left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IVLIVS-III IVLIVS-III merged commit e991dcc into builttoroam:develop Oct 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants