-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS support #471
base: develop
Are you sure you want to change the base?
macOS support #471
Conversation
…odebase with macOS.
The example app runs now and can interact with the device calendar :)
This regression was introduced when unifying the swift code with macOS.
@thomassth Do you mind looking at this if you have some spare time? Should this be a 4.4.0 release or bundled in the big 5.0? |
I wasn't able to get any calendar details when running example app in MacOS |
What do you mean by calendar details? Events in that calendar, calendar name, calendar color, readonly/read/write state of the calendar, or something different? Edit: Did you make sure, that calendar access was enabled in AppSandbox in the example app (macOS) in XCode? |
The example app isn't showing any calendar at all (the first page), and there was no details for me to click into And the calendar access was on, but I've not seen any permission popup when the app opens (usual behavior on Android) fyi I'm testing on M1 air, but I thought that should only increase compatibility with iOS code, not causing more problems :( |
hmm, interesting… it worked on my machine :(
I tested on an Intel MacBook Pro running macOS Ventura (macOS 13) |
I guess in this state we can slap a beta/Intel only label and ship it |
Attached a screen recording of how it looks on my machine… Bildschirmaufnahme.2023-02-17.um.21.46.08.mov |
I think the reason that @thomassth doesn't see any popup request calendar permission in his side caused by bug on Xcode. Just try my ideas
|
This fixes a regression and closes #474 .
Experienced the same issue as well, not sure if it's XCode's fault or something else ? flutter/flutter#122796 |
Hey @IVLIVS-III @thomassth, I would like to use device_calendar on macOS, including Apple Silicon. |
@brandonguigo I created this PR some time ago. At this point in time, multiple conflicts with the base have emerged and I have no capacity to update this right now. That‘s why I marked it as draft. This PR is not in a review-ready state right now. |
Regarding the bug discussed here earlier (i.e. permissions not working right for macOS builds launched from VSCode or Android Studio), I've gathered some likely-relevant discussions for reference:
For what it's worth, my workflow for debugging anything involving Calendar or Reminders macOS permissions right now is:
Additionally, I haven't filed a PR or even reviewed his code much, but my colleague recently created his own macOS-support fork of device_calendar here for our purposes. Sharing for reference. |
This PR adds macOS as a supported platform.
Closes #409.
As discussed on #466 we want to have a unified codebase for both iOS and macOS.
In this PR is heavily based on #466 but makes the changes necessary for a shared swift source.
The example app runs now both on iOS and macOS, with full feature support on both platforms.