-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trust buildpacks in addition to those on the builder #2230
Trust buildpacks in addition to those on the builder #2230
Conversation
Trust buildpacks provided when `--buildpack` is provided on the command line. Signed-off-by: Aidan Delaney <[email protected]>
Looks good to me. What do you think about |
Some other ideas to add to the pile :-)
|
I think |
Use the term "extra buildpacks" instead of "additional buildpacks" Signed-off-by: Aidan Delaney <[email protected]>
ed27d85
to
b195e95
Compare
Would it be possible to release this in a v0.35.1 release rather than waiting to v0.36.0 (which would presumably be further out)? :-) (I've had to remain on Pack v0.34.x locally and in CI, since otherwise #2228 means our integration tests fail. I'd love to be able to update to pick up some of the other fixes in v0.35.0 like #2197 and #2205. With this PR released I could then update our test runner to set |
@edmorley I think we could cut a v0.35.1 |
Thank you :-) Do you know when that might be? |
@edmorley we could cut it this week. I want to also land these PRs: https://github.com/buildpacks/pack/milestone/56 (The amount of actual work required is very small) |
That would be great! I know I don't have official review access, but I've reviewed those two open PRs in case it helps :-) |
Thank you for the Pack 0.35.1 release :-) |
@AidanDelaney I don't suppose you could update the PR description to match the updated arg name ( |
Trust buildpacks provided when
--buildpack
is provided on the command line.Summary
Adds a
--trust-extra-buiildpacks
which applies to those buildpacks provided in addition to the buildpacks on a trusted builder.Documentation
Related
Resolves #2228