Skip to content

Commit

Permalink
Bump default lifecycle version
Browse files Browse the repository at this point in the history
- Also bump default platform api version since lifecycle 0.6.0 implements
  a newer api.
- Move const and make private - it is only used in acceptance tests.

Signed-off-by: Natalie Arellano <[email protected]>
  • Loading branch information
natalieparellano committed Jan 27, 2020
1 parent 93436c3 commit 1aca8c1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 3 additions & 1 deletion acceptance/acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ const (

runImage = "pack-test/run"
buildImage = "pack-test/build"

defaultPlatformAPIVersion = "0.2"
)

var (
Expand Down Expand Up @@ -110,7 +112,7 @@ func TestAcceptance(t *testing.T) {
},
API: builder.LifecycleAPI{
BuildpackVersion: api.MustParse(builder.DefaultBuildpackAPIVersion),
PlatformVersion: api.MustParse(builder.DefaultPlatformAPIVersion),
PlatformVersion: api.MustParse(defaultPlatformAPIVersion),
},
}
lifecyclePath := os.Getenv(envLifecyclePath)
Expand Down
2 changes: 1 addition & 1 deletion acceptance/testdata/pack_fixtures/report_output.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Pack:
Version: {{ .Version }}
OS/Arch: {{ .OS }}/{{ .Arch }}

Default Lifecycle Version: 0.5.0
Default Lifecycle Version: 0.6.0

Config:
default-builder-image = "{{ .DefaultBuilder }}"
3 changes: 1 addition & 2 deletions internal/builder/lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ import (
)

const (
DefaultLifecycleVersion = "0.5.0"
DefaultLifecycleVersion = "0.6.0"
DefaultBuildpackAPIVersion = "0.2"
DefaultPlatformAPIVersion = "0.1"
)

type Blob interface {
Expand Down

0 comments on commit 1aca8c1

Please sign in to comment.