Skip to content

Commit

Permalink
Update a few CI steps to node 18
Browse files Browse the repository at this point in the history
We upgraded docs to node 18 in #2066, way back in April 2023. However,
the nvmrc and some CI steps were left running on node 16.

That hasn't been a problem until today, when I tried to update
netlify-cli to a version that requires node 18 at a minimum. I thought
I'd sneak these changes into the netlify PR, since they're CI only and
don't impact prod.

alpine 3.16 isn't the latest alpine, but it's the one that has node 18
rather than node 20.
  • Loading branch information
yob committed Sep 21, 2024
1 parent 9940c5e commit e36c510
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
12 changes: 5 additions & 7 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ steps:
login: true
account-ids: public.ecr.aws
- docker#v3.7.0:
image: "public.ecr.aws/docker/library/node:lts-alpine3.14"
image: "public.ecr.aws/docker/library/node:lts-alpine3.16"

- label: ":lint-roller: Linting text and markdown"
agents:
Expand All @@ -83,9 +83,7 @@ steps:
# version, is way faster because we don't have to wait for Ruby gems to
# install.
- docker#v3.7.0:
# Alpine 3.14 - EOS 01 May 2023
# lts = Node 1415.1 - 2023-04-30
image: "public.ecr.aws/docker/library/node:lts-alpine3.14"
image: "public.ecr.aws/docker/library/node:lts-alpine3.16"

- label: "Validate YAML"
command:
Expand All @@ -100,7 +98,7 @@ steps:
login: true
account-ids: public.ecr.aws
- docker#v3.7.0:
image: "public.ecr.aws/docker/library/node:lts-alpine3.14"
image: "public.ecr.aws/docker/library/node:lts-alpine3.16"

- label: ":lint-roller: :markdown: Linting the Markdown"
command: npm run -y mdlint
Expand All @@ -113,7 +111,7 @@ steps:
login: true
account-ids: public.ecr.aws
- docker#v3.7.0:
image: "public.ecr.aws/docker/library/node:lts-alpine3.14"
image: "public.ecr.aws/docker/library/node:lts-alpine3.16"

- label: ":snake: Linting markdown files for snake case"
command: npx -y @ls-lint/[email protected]
Expand All @@ -126,7 +124,7 @@ steps:
login: true
account-ids: public.ecr.aws
- docker#v3.7.0:
image: "public.ecr.aws/docker/library/node:lts-alpine3.14"
image: "public.ecr.aws/docker/library/node:lts-alpine3.16"

- label: ":rspec: RSpec"
depends_on: linting
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.19.1
18.16.0

0 comments on commit e36c510

Please sign in to comment.