Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-root hosts failing on resolving DNS #2269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix non-root hosts failing on resolving DNS #2269

wants to merge 1 commit into from

Commits on Nov 8, 2024

  1. Fix non-root hosts failing on resolving DNS 

    A fix for a bug introduced by btcsuite#2168

Previously, config.Host worked in the following way:
1. Documented as supporting ip addresses only
2. In fact supported "host/path" syntax
3. Did not support "scheme" prefixes, i.e. https://

Not sure this is the desired approach, probably the best thing would
have been to extend config to contain "Scheme" and "Path" fields as well.

However, this was the way it worked.

1. Now Host can contain scheme prefixes "unix://..."
2. Host can no longer contain ".../path"

This PR solves this behavior while maintaining support of the "unix://" flow
as well.

For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that.

Also remove disambiguation in "network:address:port", where it parsed
"myhost:8888" as network:address instead address:port.
    @same-id
    same-id committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    47faac8 View commit details
    Browse the repository at this point in the history