Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the displayPaymentEU hook #88

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

BitcoinMitchell
Copy link
Collaborator

@BitcoinMitchell BitcoinMitchell commented Nov 15, 2023

Questions Answers
Description? This merge request resolves the second issue reported by nethek on Mattermost.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -

From what I can see online it used to be used by certain modules, but is very badly documented and doesn't seem to benefit us at all, so let's just remove it.


Base automatically changed from ensure-client-is-available-validation to 6.x November 15, 2023 20:47
Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, seems to make no sense, tested and works 👍

@BitcoinMitchell BitcoinMitchell merged commit 70f263b into 6.x Nov 15, 2023
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the remove-hookDisplayPaymentEU branch November 15, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants