Merge pull request Expensify#48135 from Expensify/revert-47472-fixOnb…

…oardingURLChange Revert "Make onboarding continue from last visited onboarding page"
brunovjk · Aug 27, 2024 · b217d11 · b217d11
2 parents 25ed997 + 7be6144
commit b217d11
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 72 deletions.
diff --git a/src/ONYXKEYS.ts b/src/ONYXKEYS.ts
@@ -336,9 +336,6 @@ const ONYXKEYS = {
     /** Onboarding Purpose selected by the user during Onboarding flow */
     ONBOARDING_ADMINS_CHAT_REPORT_ID: 'onboardingAdminsChatReportID',
 
-    // Stores onboarding last visited path
-    ONBOARDING_LAST_VISITED_PATH: 'onboardingLastVisitedPath',
-
     // Max width supported for HTML <canvas> element
     MAX_CANVAS_WIDTH: 'maxCanvasWidth',
 
@@ -885,7 +882,6 @@ type OnyxValuesMapping = {
     [ONYXKEYS.ONBOARDING_ERROR_MESSAGE]: string;
     [ONYXKEYS.ONBOARDING_POLICY_ID]: string;
     [ONYXKEYS.ONBOARDING_ADMINS_CHAT_REPORT_ID]: string;
-    [ONYXKEYS.ONBOARDING_LAST_VISITED_PATH]: string;
     [ONYXKEYS.IS_SEARCHING_FOR_REPORTS]: boolean;
     [ONYXKEYS.LAST_VISITED_PATH]: string | undefined;
     [ONYXKEYS.VERIFY_3DS_SUBSCRIPTION]: string;

diff --git a/src/components/ExplanationModal.tsx b/src/components/ExplanationModal.tsx
@@ -4,6 +4,7 @@ import Navigation from '@libs/Navigation/Navigation';
 import variables from '@styles/variables';
 import * as Welcome from '@userActions/Welcome';
 import CONST from '@src/CONST';
+import ROUTES from '@src/ROUTES';
 import FeatureTrainingModal from './FeatureTrainingModal';
 
 function ExplanationModal() {
@@ -17,7 +18,7 @@ function ExplanationModal() {
             onNotCompleted: () => {
                 setTimeout(() => {
                     Navigation.isNavigationReady().then(() => {
-                        Welcome.startOnboardingFlow();
+                        Navigation.navigate(ROUTES.ONBOARDING_ROOT.route);
                     });
                 }, variables.welcomeVideoDelay);
             },

diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx
@@ -13,7 +13,9 @@ import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import * as Session from '@libs/actions/Session';
 import interceptAnonymousUser from '@libs/interceptAnonymousUser';
-import Navigation from '@libs/Navigation/Navigation';
+import linkingConfig from '@libs/Navigation/linkingConfig';
+import getAdaptedStateFromPath from '@libs/Navigation/linkingConfig/getAdaptedStateFromPath';
+import Navigation, {navigationRef} from '@libs/Navigation/Navigation';
 import type {RootStackParamList, State} from '@libs/Navigation/types';
 import {isCentralPaneName} from '@libs/NavigationUtils';
 import * as PolicyUtils from '@libs/PolicyUtils';
@@ -93,7 +95,10 @@ function BottomTabBar({selectedTab}: BottomTabBarProps) {
         }
 
         Welcome.isOnboardingFlowCompleted({
-            onNotCompleted: () => Welcome.startOnboardingFlow(),
+            onNotCompleted: () => {
+                const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT.route, linkingConfig.config);
+                navigationRef.resetRoot(adaptedState);
+            },
         });
 
         // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps

diff --git a/src/libs/Navigation/NavigationRoot.tsx b/src/libs/Navigation/NavigationRoot.tsx
@@ -14,12 +14,10 @@ import hasCompletedGuidedSetupFlowSelector from '@libs/hasCompletedGuidedSetupFl
 import Log from '@libs/Log';
 import {getPathFromURL} from '@libs/Url';
 import {updateLastVisitedPath} from '@userActions/App';
-import {updateOnboardingLastVisitedPath} from '@userActions/Welcome';
-import * as Welcome from '@userActions/Welcome';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
-import ROUTES from '@src/ROUTES';
 import type {Route} from '@src/ROUTES';
+import ROUTES from '@src/ROUTES';
 import AppNavigator from './AppNavigator';
 import getPolicyIDFromState from './getPolicyIDFromState';
 import linkingConfig from './linkingConfig';
@@ -60,9 +58,6 @@ function parseAndLogRoute(state: NavigationState) {
 
     if (focusedRoute && !CONST.EXCLUDE_FROM_LAST_VISITED_PATH.includes(focusedRoute?.name)) {
         updateLastVisitedPath(currentPath);
-        if (currentPath.startsWith(`/${ROUTES.ONBOARDING_ROOT.route}`)) {
-            updateOnboardingLastVisitedPath(currentPath);
-        }
     }
 
     // Don't log the route transitions from OldDot because they contain authTokens
@@ -103,7 +98,7 @@ function NavigationRoot({authenticated, lastVisitedPath, initialUrl, onReady, sh
         // If the user haven't completed the flow, we want to always redirect them to the onboarding flow.
         // We also make sure that the user is authenticated.
         if (!hasCompletedGuidedSetupFlow && authenticated && !shouldShowRequire2FAModal) {
-            const {adaptedState} = getAdaptedStateFromPath(Welcome.getOnboardingInitialPath(), linkingConfig.config);
+            const {adaptedState} = getAdaptedStateFromPath(ROUTES.ONBOARDING_ROOT.route, linkingConfig.config);
             return adaptedState;
         }
 

diff --git a/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts b/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts
@@ -47,7 +47,7 @@ type GetAdaptedStateReturnType = {
     metainfo: Metainfo;
 };
 
-type GetAdaptedStateFromPath = (...args: [...Parameters<typeof getStateFromPath>, shouldReplacePathInNestedState?: boolean]) => GetAdaptedStateReturnType;
+type GetAdaptedStateFromPath = (...args: Parameters<typeof getStateFromPath>) => GetAdaptedStateReturnType;
 
 // The function getPathFromState that we are using in some places isn't working correctly without defined index.
 const getRoutesWithIndex = (routes: NavigationPartialRoute[]): PartialState<NavigationState> => ({routes, index: routes.length - 1});
@@ -365,7 +365,7 @@ function getAdaptedState(state: PartialState<NavigationState<RootStackParamList>
     };
 }
 
-const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options, shouldReplacePathInNestedState = true) => {
+const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options) => {
     const normalizedPath = !path.startsWith('/') ? `/${path}` : path;
     const pathWithoutPolicyID = getPathWithoutPolicyID(normalizedPath);
     const isAnonymous = isAnonymousUser();
@@ -374,9 +374,7 @@ const getAdaptedStateFromPath: GetAdaptedStateFromPath = (path, options, shouldR
     const policyID = isAnonymous ? undefined : extractPolicyIDFromPath(path);
 
     const state = getStateFromPath(pathWithoutPolicyID, options) as PartialState<NavigationState<RootStackParamList>>;
-    if (shouldReplacePathInNestedState) {
-        replacePathInNestedState(state, path);
-    }
+    replacePathInNestedState(state, path);
     if (state === undefined) {
         throw new Error('Unable to parse path');
     }

diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts
@@ -2701,9 +2701,7 @@ function openReportFromDeepLink(url: string) {
 
                         // We need skip deeplinking if the user hasn't completed the guided setup flow.
                         if (!hasCompletedGuidedSetupFlow) {
-                            Welcome.isOnboardingFlowCompleted({
-                                onNotCompleted: () => Welcome.startOnboardingFlow(),
-                            });
+                            Welcome.isOnboardingFlowCompleted({onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_ROOT.getRoute())});
                             return;
                         }
 

diff --git a/src/libs/actions/Welcome.ts b/src/libs/actions/Welcome.ts
@@ -3,24 +3,18 @@ import type {OnyxUpdate} from 'react-native-onyx';
 import Onyx from 'react-native-onyx';
 import * as API from '@libs/API';
 import {WRITE_COMMANDS} from '@libs/API/types';
-import linkingConfig from '@libs/Navigation/linkingConfig';
-import Navigation, {navigationRef} from '@libs/Navigation/Navigation';
-import getStateFromPath from '@navigation/getStateFromPath';
-import getAdaptedStateFromPath from '@navigation/linkingConfig/getAdaptedStateFromPath';
+import Navigation from '@libs/Navigation/Navigation';
 import variables from '@styles/variables';
 import type {OnboardingPurposeType} from '@src/CONST';
-import NAVIGATORS from '@src/NAVIGATORS';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
-import type {Route} from '@src/ROUTES';
 import type Onboarding from '@src/types/onyx/Onboarding';
 import type TryNewDot from '@src/types/onyx/TryNewDot';
 
 type OnboardingData = Onboarding | [] | undefined;
 
 let isLoadingReportData = true;
 let tryNewDotData: TryNewDot | undefined;
-let onboardingInitialPath = '';
 let onboarding: OnboardingData;
 
 type HasCompletedOnboardingFlowProps = {
@@ -52,18 +46,15 @@ function onServerDataReady(): Promise<void> {
     return isServerDataReadyPromise;
 }
 
-let isOnboardingInProgress = false;
 function isOnboardingFlowCompleted({onCompleted, onNotCompleted}: HasCompletedOnboardingFlowProps) {
     isOnboardingFlowStatusKnownPromise.then(() => {
         if (Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) {
             return;
         }
 
         if (onboarding?.hasCompletedGuidedSetupFlow) {
-            isOnboardingInProgress = false;
             onCompleted?.();
-        } else if (!isOnboardingInProgress) {
-            isOnboardingInProgress = true;
+        } else {
             onNotCompleted?.();
         }
     });
@@ -106,7 +97,7 @@ function handleHybridAppOnboarding() {
             isOnboardingFlowCompleted({
                 onNotCompleted: () =>
                     setTimeout(() => {
-                        startOnboardingFlow();
+                        Navigation.navigate(ROUTES.ONBOARDING_ROOT.route);
                     }, variables.explanationModalDelay),
             }),
     });
@@ -161,19 +152,6 @@ function setOnboardingPolicyID(policyID?: string) {
     Onyx.set(ONYXKEYS.ONBOARDING_POLICY_ID, policyID ?? null);
 }
 
-function updateOnboardingLastVisitedPath(path: string) {
-    Onyx.merge(ONYXKEYS.ONBOARDING_LAST_VISITED_PATH, path);
-}
-
-function getOnboardingInitialPath(): Route {
-    const state = getStateFromPath(onboardingInitialPath as Route);
-    if (state?.routes?.at(-1)?.name !== NAVIGATORS.ONBOARDING_MODAL_NAVIGATOR) {
-        return ROUTES.ONBOARDING_ROOT.route as Route;
-    }
-
-    return onboardingInitialPath as Route;
-}
-
 function completeHybridAppOnboarding() {
     const optimisticData: OnyxUpdate[] = [
         {
@@ -202,11 +180,6 @@ function completeHybridAppOnboarding() {
     API.write(WRITE_COMMANDS.COMPLETE_HYBRID_APP_ONBOARDING, {}, {optimisticData, failureData});
 }
 
-function startOnboardingFlow() {
-    const {adaptedState} = getAdaptedStateFromPath(getOnboardingInitialPath(), linkingConfig.config, false);
-    navigationRef.resetRoot(adaptedState);
-}
-
 Onyx.connect({
     key: ONYXKEYS.NVP_ONBOARDING,
     callback: (value) => {
@@ -215,18 +188,6 @@ Onyx.connect({
     },
 });
 
-const onboardingLastVisitedPathConnection = Onyx.connect({
-    key: ONYXKEYS.ONBOARDING_LAST_VISITED_PATH,
-    callback: (value) => {
-        if (value === undefined) {
-            return;
-        }
-
-        onboardingInitialPath = value.substring(1);
-        Onyx.disconnect(onboardingLastVisitedPathConnection);
-    },
-});
-
 Onyx.connect({
     key: ONYXKEYS.IS_LOADING_REPORT_DATA,
     initWithStoredValues: false,
@@ -252,21 +213,16 @@ function resetAllChecks() {
         resolveOnboardingFlowStatus = resolve;
     });
     isLoadingReportData = true;
-    onboardingInitialPath = '';
-    isOnboardingInProgress = false;
 }
 
 export {
     onServerDataReady,
     isOnboardingFlowCompleted,
     setOnboardingPurposeSelected,
-    getOnboardingInitialPath,
-    updateOnboardingLastVisitedPath,
     resetAllChecks,
     setOnboardingAdminsChatReportID,
     setOnboardingPolicyID,
     completeHybridAppOnboarding,
     handleHybridAppOnboarding,
     setOnboardingErrorMessage,
-    startOnboardingFlow,
 };
diff --git a/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx b/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
@@ -73,9 +73,7 @@ function BaseOnboardingPersonalDetails({
             Welcome.setOnboardingAdminsChatReportID();
             Welcome.setOnboardingPolicyID();
 
-            // Navigate to HOME instead of dismissModal, because there is bug in small screen
-            // where the onboarding puropose page will be disaplayed briefly
-            Navigation.navigate(ROUTES.HOME);
+            Navigation.dismissModal();
 
             // Only navigate to concierge chat when central pane is visible
             // Otherwise stay on the chats screen.