Skip to content

Commit

Permalink
Merge pull request Expensify#30213 from ahmedGaber93/issue-29923
Browse files Browse the repository at this point in the history
reduce label size and remove placeholder in new chat room
  • Loading branch information
danieldoglas committed Oct 26, 2023
2 parents 2c52130 + 48dbc7b commit 414d591
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/components/ValuePicker/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import MenuItemWithTopDescription from '../MenuItemWithTopDescription';
import ValueSelectorModal from './ValueSelectorModal';
import FormHelpMessage from '../FormHelpMessage';
import refPropTypes from '../refPropTypes';
import * as StyleUtils from '../../styles/StyleUtils';
import variables from '../../styles/variables';

const propTypes = {
/** Form Error description */
Expand Down Expand Up @@ -59,7 +61,7 @@ function ValuePicker({value, label, items, placeholder, errorText, onInputChange
hidePickerModal();
};

const descStyle = value.length === 0 ? styles.textNormal : null;
const descStyle = value.length === 0 ? StyleUtils.getFontSizeStyle(variables.fontSizeLabel) : null;
const selectedItem = _.find(items, {value});
const selectedLabel = selectedItem ? selectedItem.label : '';

Expand Down
1 change: 0 additions & 1 deletion src/pages/workspace/WorkspaceNewRoomPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ function WorkspaceNewRoomPage(props) {
<ValuePicker
inputID="policyID"
label={translate('workspace.common.workspace')}
placeholder={translate('newRoomPage.selectAWorkspace')}
items={workspaceOptions}
onValueChange={setPolicyID}
/>
Expand Down

0 comments on commit 414d591

Please sign in to comment.