Skip to content

Commit

Permalink
Look up the Ubuntu code name in github-ci-linux-get-dependencies.sh
Browse files Browse the repository at this point in the history
Save an additional change every time ubuntu-latest is updated.

An unknown code name causes an error.
  • Loading branch information
cjmayo committed Jun 4, 2024
1 parent 8afb6c9 commit e5fa785
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/linux-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,10 @@ jobs:
qt: qt6
include:
- os: ubuntu-20.04
distro: focal
qt5default: true
- os: ubuntu-22.04
distro: jammy
qt5default: false
- os: ubuntu-24.04
distro: noble
qt5default: false

runs-on: ${{ matrix.os }}
Expand All @@ -41,7 +38,7 @@ jobs:
with:
submodules: 'recursive'
- name: Install dependencies
run: ./scripts/github-ci-linux-get-dependencies.sh ${{ matrix.distro }} ${{ matrix.qt }}
run: ./scripts/github-ci-linux-get-dependencies.sh ${{ matrix.qt }}
- name: Make Qt5 the default
if: ${{ matrix.qt5default }}
run: sudo apt-get install qt5-default
Expand Down
5 changes: 2 additions & 3 deletions scripts/github-ci-linux-get-dependencies.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
#!/bin/bash

DIST="$1"
QT="$2"
QT="$1"

[[ -z "$DIST" ]] && DIST="jammy" # ubuntu-latest
DIST=$(. /etc/os-release; echo $VERSION_CODENAME)

PACKAGES1="build-essential bison cmake curl flex gettext git-core imagemagick ghostscript"
PACKAGES2="libboost-all-dev libboost-dev libeigen3-dev libzip-dev libcrypto++-dev"
Expand Down

0 comments on commit e5fa785

Please sign in to comment.