Fix freed memory access issue: A vector may be resized during use, wh…

…ich would invalidate all pointers into it (openscad#5270)
brucerennie · Aug 25, 2024 · 660dd12 · 660dd12
1 parent 392223e
commit 660dd12
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/glview/cgal/CGAL_OGL_VBO_helper.h b/src/glview/cgal/CGAL_OGL_VBO_helper.h
@@ -153,12 +153,10 @@ class VBOPolyhedron : public virtual Polyhedron
   }
 
   static inline void CGAL_GLU_TESS_CALLBACK combineCallback(GLdouble coords[3], GLvoid *[4], GLfloat [4], GLvoid **dataOut) {
-    static std::vector<GLdouble> vertexCache;
+    static std::vector<std::unique_ptr<Vector3d>> vertexCache;
     if (dataOut) {
-      vertexCache.push_back(coords[0]);
-      vertexCache.push_back(coords[1]);
-      vertexCache.push_back(coords[2]);
-      *dataOut = &(vertexCache.back()) - 2;
+      vertexCache.push_back(std::make_unique<Vector3d>(coords));
+      *dataOut = vertexCache.back().get();
     } else {
       vertexCache.clear();
     }