Merge branch 'fix-jupyter-display' into main

brucala · Jul 15, 2023 · 69a7dba · 69a7dba · brucala · Jul 15, 2023
2 parents 1b12a01 + f9459bd
commit 69a7dba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,13 +1,14 @@
 name = "Deneb"
 uuid = "b5a61f88-a05b-4725-9526-4eca17cec623"
 authors = ["brucala <[email protected]>"]
-version = "0.2.1"
+version = "0.3.0"
 
 [deps]
 DefaultApplication = "3f0dd361-4fe0-5fc6-8523-80b14ec94d85"
 JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
 MultilineStrings = "1e8d2bf6-9821-4900-9a2f-4d87552df2bd"
 NodeJS_18_jll = "c1e1d063-8311-5f52-a749-c7b05e91ae37"
+REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"
 Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
 UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 

diff --git a/src/Deneb.jl b/src/Deneb.jl
@@ -5,6 +5,7 @@ using NodeJS_18_jll
 using JSON, Tables
 using MultilineStrings: indent
 using DefaultApplication
+using REPL
 
 const SymbolOrString = Union{Symbol, AbstractString}
 

diff --git a/src/render.jl b/src/render.jl
@@ -229,7 +229,7 @@ end
 ### Display in a browser
 ###
 
-function Base.display(spec::VegaLiteSpec)
+function Base.display(::REPL.REPLDisplay, spec::VegaLiteSpec)
     # write html in temporary file
     path = tempname() * ".html"
     write(path, html(spec))