Skip to content

Commit

Permalink
updating to 4.4.3 version
Browse files Browse the repository at this point in the history
  • Loading branch information
sunny-se committed Apr 7, 2024
1 parent 923bbbd commit b6324ff
Show file tree
Hide file tree
Showing 9 changed files with 101 additions and 428 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [4.4.3](https://github.com/dequelabs/axe-core/compare/v4.4.2...v4.4.3) (2022-07-13)

### Bug Fixes

- **axe.d.ts:** updates type definition for Rule to add reviewOnFail ([#3521](https://github.com/dequelabs/axe-core/issues/3521)) ([afb2478](https://github.com/dequelabs/axe-core/commit/afb247844e697475f5bf81fd7b03ed30c2c65830))
- Continue supporting Node >=4 ([#3538](https://github.com/dequelabs/axe-core/issues/3538)) ([da7923b](https://github.com/dequelabs/axe-core/commit/da7923bd5bcaa71f52f6b4e6b8eece1ea12c1c2a)), closes [#3537](https://github.com/dequelabs/axe-core/issues/3537)

### [4.4.2](https://github.com/dequelabs/axe-core/compare/v4.4.1...v4.4.2) (2022-05-12)

### Bug Fixes
Expand Down
33 changes: 0 additions & 33 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,36 +1,3 @@
# a11y-engine-axe-core
This is a private fork of public Axe core repo:
https://github.com/dequelabs/axe-core


## How to make changes in axe-core internally
Create a feature branch, add the changes and raise a PR to the `main` branch.

NOTE: `axe-core` public repo already has a master branch, to keep the things clean while merging we avoid make changes on top of it.


## Using the repo as submodule
To use this repo as a submodule, make sure to use `main` branch as the submodule commit head.

This we way can track the changes in a cleaner way.
For development and development testing however we can rely on some other commits in the submodule.

## Pull latest changes from public axe-core repo

```
# cd into the repo
cd a11y-engine-axe-core
# Add public axe-core repo as remote public
git remote add public [email protected]:dequelabs/axe-core.git
# Creates a merge commit
git pull public master
# push the changes to internal private repo
git push origin master
```

# axe-core

[![License](https://img.shields.io/npm/l/axe-core.svg)](LICENSE)
Expand Down
1 change: 1 addition & 0 deletions axe.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ declare namespace axe {
none?: string[];
tags?: string[];
matches?: string;
reviewOnFail?: boolean;
}
interface AxePlugin {
id: string;
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "axe-core",
"version": "4.4.2",
"version": "4.4.3",
"contributors": [
{
"name": "David Sturley",
Expand Down
30 changes: 6 additions & 24 deletions lib/core/base/rule.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,21 +146,14 @@ Rule.prototype.gather = function gather(context, options = {}) {
performanceTimer.measure(
'rule_' + this.id + '#gather_axe.utils.isHidden',
markHiddenStart,
markHiddenEnd,
{
rule: this.id,
type: "rule"
}
markHiddenEnd
);
}
}

if (options.performanceTimer) {
performanceTimer.mark(markEnd);
performanceTimer.measure('rule_' + this.id + '#gather', markStart, markEnd, {
rule: this.id,
type: "rule"
});
performanceTimer.measure('rule_' + this.id + '#gather', markStart, markEnd);
}

return elements;
Expand Down Expand Up @@ -375,7 +368,7 @@ Rule.prototype._trackPerformance = function _trackPerformance() {
* @param {Array} nodes Result of rule.gather
*/
Rule.prototype._logGatherPerformance = function _logGatherPerformance(nodes) {
// log('gather (', nodes.length, '):', performanceTimer.timeElapsed() + 'ms');
log('gather (', nodes.length, '):', performanceTimer.timeElapsed() + 'ms');
performanceTimer.mark(this._markChecksStart);
};

Expand All @@ -390,17 +383,10 @@ Rule.prototype._logRulePerformance = function _logRulePerformance() {
performanceTimer.measure(
'runchecks_' + this.id,
this._markChecksStart,
this._markChecksEnd,
{
rule: this.id,
type: "rule"
}
this._markChecksEnd
);

performanceTimer.measure('rule_' + this.id, this._markStart, this._markEnd, {
rule: this.id,
type: "rule"
});
performanceTimer.measure('rule_' + this.id, this._markStart, this._markEnd);
};

/**
Expand Down Expand Up @@ -458,11 +444,7 @@ Rule.prototype.gatherAndMatchNodes = function gatherAndMatchNodes(
performanceTimer.measure(
'rule_' + this.id + '#matches',
markMatchesStart,
markMatchesEnd,
{
rule: this.id,
type: "rule"
}
markMatchesEnd
);
}

Expand Down
18 changes: 4 additions & 14 deletions lib/core/utils/performance-timer.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const performanceTimer = (() => {
this.mark('mark_axe_end');
this.measure('axe', 'mark_axe_start', 'mark_axe_end');

// this.logMeasures('axe');
this.logMeasures('axe');
},
/**
* @member {Function} auditStart Starts an audit for a page or frame
Expand All @@ -52,7 +52,7 @@ const performanceTimer = (() => {
this.mark('mark_audit_end');
this.measure('audit_start_to_end', 'mark_audit_start', 'mark_audit_end');
// log audit/rule measures
// this.logMeasures();
this.logMeasures();
},
/**
* @member {Function} mark Shims creating a new named time stamp, called a mark
Expand All @@ -72,19 +72,9 @@ const performanceTimer = (() => {
* @param {String} startMark String name of mark to start measuring
* @param {String} endMark String name of mark to end measuring
*/
measure(measureName, startMark, endMark, details = {}) {
measure(measureName, startMark, endMark) {
if (window.performance && window.performance.measure !== undefined) {
if(Object.keys(details).length > 0) {
const measureOpts = {
detail: details,
start: startMark,
end: endMark
};
window.performance.measure(measureName, measureOpts);
}
else {
window.performance.measure(measureName, startMark, endMark);
}
window.performance.measure(measureName, startMark, endMark);
}
},
/**
Expand Down
Loading

0 comments on commit b6324ff

Please sign in to comment.