Have alignments placed if HTML is on #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one half of #270.
#271 tries to provide a
sanitizeOptions
, which is perhaps more extensible. But such a function will have to be called at several sites increasing verbosity is my conclusion after experimenting in jerinphilip#28.Instead, we just pick-up
ResponseOptions.HTML
and place alignments with anor
switch ifHTML
is on, irrespective of whatever value was given forAlignment
s.This way a client can go from:
to
(This is tested with python-cmdline).
Should work similarly with
ResponseOptions
for WebAssembly as well.