Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff page and cards #43

Merged
merged 15 commits into from
May 31, 2024
Merged

Staff page and cards #43

merged 15 commits into from
May 31, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented May 29, 2024

Resolves #6 and #22

Additions

Added five people via staticCMS, along with their photos

Pages

people.astro : the people page, which displays staff and advisors

Components

Card.tsx : rounded image (non-mobile only) with staff info
CardContainer.astro: Staff category title with shared styles

Changes

Consts.ts: added a people path to routes
public/config.yml: made certain fields optional in staticCMS
src/content/config.ts: added a people collection to astro

@hetd54 hetd54 requested review from broarr and galenwinsor May 29, 2024 20:05
Copy link

github-actions bot commented May 29, 2024

Visit the preview URL for this PR (updated for commit a1ee544):

https://mmp-site-b1c9b--pr43-staff-cards-u9cxl93u.web.app

(expires Thu, 06 Jun 2024 16:33:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link
Collaborator

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two small comments. They really need to get better images lol.

src/components/Card.tsx Outdated Show resolved Hide resolved
src/pages/people.astro Show resolved Hide resolved
@hetd54 hetd54 requested a review from galenwinsor May 30, 2024 16:29
@hetd54 hetd54 merged commit 47073c5 into main May 31, 2024
2 checks passed
@hetd54 hetd54 deleted the staff-cards branch May 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Cards
2 participants