Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implementation of Device Code Flow Integration in Vapor OAuth #24

Closed

Conversation

vamsii777
Copy link

I am re-submitting the integration of Device Code Flow into Vapor OAuth, as a fresh pull request following issues encountered with the previous PR #17 . This PR contains the same set of changes and updates that were intended in the original submission.

Key Aspects:

  • Reintroduction of the Device Code Flow in accordance with RFC 8628.
  • Reimplementation of the DeviceCodeTokenHandler for handling device code token requests.
  • Revalidation of test cases to ensure correct handling of device code expiration.
  • The changes here mirror those in the original PR, but with a fresh commit history and resolution of previous issues.

Reason for New PR:
The decision to create a new PR was due to complications with the original one, including review challenges. This fresh PR will help in maintaining a cleaner and more organized code history.

Please refrain from merging this PR until I have given the explicit go-ahead. I will update this thread and provide a clear notification once it is ready for final review and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant