Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Android namespace #89

Merged
merged 7 commits into from
Sep 16, 2023
Merged

Adds Android namespace #89

merged 7 commits into from
Sep 16, 2023

Conversation

asaarnak
Copy link
Contributor

Adds a namespace attribute to the Android build.gradle, for compatibility with Android Gradle Plugin 8.0.
See:
flutter/packages@6284c2d

Adds a namespace attribute to the Android build.gradle, for compatibility with Android Gradle Plugin 8.0.
Adds a namespace attribute to the Android build.gradle, for compatibility with Android Gradle Plugin 8.0.
@cuong0993
Copy link

Can we merge this change and release an update?

@britannio
Copy link
Owner

Can we merge this change and release an update?

I'll need to test it out, what's the significance of the change? Is anything broken?

@cuong0993
Copy link

cuong0993 commented May 11, 2023

It will fix the build if using AGP 8.
Build error can be found here https://github.com/cuong0993/issue/blob/master/pubspec.yaml#L39
image

Some popular packages already did it.
firebase/flutterfire@a3b9673
fluttercommunity/plus_plugins@4faa5d8

@asaarnak
Copy link
Contributor Author

Can we merge this change and release an update?

I'll need to test it out, what's the significance of the change? Is anything broken?

Shouldn't break anything, just adds AGP 8 support.

@under3415
Copy link

I was able to build the project with Gradle 8 after referring to this fork in pubspec.yaml:

in_app_review: 
    git: 
      url: https://github.com/asaarnak/in_app_review.git
      ref: patch-1
      path: in_app_review

@davidmartos96
Copy link

@britannio Any chance to publish a https://pub.dev version with this?

@AndreaMinato
Copy link

@britannio Can confirm it builds no problem with this changes

@NachiketaVadera
Copy link

hey @britannio

any plans to release this update?

@britannio britannio merged commit 1f0f370 into britannio:master Sep 16, 2023
8 checks passed
@britannio
Copy link
Owner

Thanks for the contribution, this will be published shortly!

@tushar0518
Copy link

any update for releasing the new version? @britannio

@britannio
Copy link
Owner

any update for releasing the new version? @britannio

Yeah, my laptop is in repair until ~Thursday. You can depend on the latest git version until then and I'll leave a comment when the release is out.

@absar
Copy link

absar commented Oct 11, 2023

It needs to be released soon, since most of the plugins are upgraded to AGP 8, this plugin is preventing Apps from upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants