WIP: Upgrade to Rails 4.1 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `rake test:environments` which iterates over `test/environments` and runs each file in a separate ruby process (to isolate requires) - Check presence of multiple files (.envrc, .env.example, bin/setup, etc) - Check AR validation errors are logged - Ensure presence of gems, bins and assets - Ensure SSL required in production
| Rails.application.load_tasks | ||
|
|
||
| Rake::Task['default'].clear | ||
| task default: 'test:all' |
There was a problem hiding this comment.
You should be able to just run rake now. Or better yet autotest.
| @@ -0,0 +1,8 @@ | |||
| namespace :test do | |||
| desc "Run environment tests for each environment" | |||
| task environments: :environment do | |||
There was a problem hiding this comment.
Fancy new tests to test this rails-template. This does not get called with rake test:all (maybe it should?). Call rake test:environments separately to ensure all is well.
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a PR to track my progress.
Here's what's left:
DATABASE_URLin.envcurl -L http://git.io/KebUPw|patch -p1