Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CKV_AZURE_167 to correct check on retention policy #6758

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paddymorgan84
Copy link

@paddymorgan84 paddymorgan84 commented Oct 8, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Update the ACREnableRetentionPolicy class to correct the retention policy check by changing the inspected key to retention_policy_in_days and ensuring it expects any value. Modify the test cases to align with the new retention policy structure, removing outdated test scenarios.

TopicDetails
Test Case Adjustment Modify the test cases to align with the new retention policy structure, removing outdated test scenarios.
Modified files (2)
  • tests/terraform/checks/resource/azure/test_ACREnableRetentionPolicy.py
  • tests/terraform/checks/resource/azure/example_ACREnableRetentionPolicy/main.tf
Latest Contributors(1)
EmailCommitDate
james.woolfenden@gmail...feat-terraform-new-azu...December 28, 2022
Retention Policy Update Update the ACREnableRetentionPolicy class to correct the retention policy check by changing the inspected key to retention_policy_in_days and ensuring it expects any value.
Modified files (1)
  • checkov/terraform/checks/resource/azure/ACREnableRetentionPolicy.py
Latest Contributors(1)
EmailCommitDate
james.woolfenden@gmail...feat-terraform-azurerm...November 28, 2022
This pull request is reviewed by Baz. Join @paddymorgan84 and the rest of your team on (Baz).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant