Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CKV_AZURE_171 to check automatic_upgrade_channel #6756

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paddymorgan84
Copy link

@paddymorgan84 paddymorgan84 commented Oct 8, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #6681

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes


Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Update the AKSUpgradeChannel class to correct the key from automatic_channel_upgrade to automatic_upgrade_channel. This change ensures the policy check aligns with the correct Azure resource property. Adjust the test cases in example_AKSUpgradeChannel/main.tf to reflect this key change, ensuring both passing and failing scenarios are accurately tested.

TopicDetails
Test Update Update test cases to reflect the corrected key in example_AKSUpgradeChannel.
Modified files (1)
  • tests/terraform/checks/resource/azure/example_AKSUpgradeChannel/main.tf
Latest Contributors(1)
EmailCommitDate
james.woolfenden@gmail...feat-terraform-new-azu...December 28, 2022
Key Correction Correct the key in AKSUpgradeChannel to ensure accurate policy checks.
Modified files (1)
  • checkov/terraform/checks/resource/azure/AKSUpgradeChannel.py
Latest Contributors(1)
EmailCommitDate
james.woolfenden@gmail...feat-terraform-new-aks...December 06, 2022
This pull request is reviewed by Baz. Join @paddymorgan84 and the rest of your team on (Baz).

@paddymorgan84
Copy link
Author

Fixes #6681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV_AZURE_171 doesn't handle property rename in AzureRM provider 4.x
1 participant