feat(general): add support for windows 10 for aiohttp #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamDev
had a problem deploying
to
scan-security
GitHub Actions
Failure
AdamDev
had a problem deploying
to
scan-security
GitHub Actions
Failure
AdamDev
had a problem deploying
to
scan-security
GitHub Actions
Failure
AdamDev
temporarily deployed
to
scan-security
GitHub Actions
Inactive
AdamDev
changed the title
AdamDev
changed the title
Saarett
reviewed
Sep 1, 2024
Comment on lines
367
to
371
| @staticmethod | ||
| def set_config(): | ||
| # asyncio - on windows aiodns needs SelectorEventLoop | ||
| if sys.platform == 'win32': | ||
| asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) |
There was a problem hiding this comment.
@AdamDev How does it solve the issue?
There was a problem hiding this comment.
This issue exists in many places in the network, this is the suggested solution:
aio-libs/aiodns#86 (comment)
Root cause:
aio-libs/aiodns#86 (comment)
AdamDev
temporarily deployed
to
scan-security
GitHub Actions
Inactive
AdamDev
temporarily deployed
to
scan-security
GitHub Actions
Inactive
ChananM
approved these changes
Sep 1, 2024
AdamDev
temporarily deployed
to
scan-security
GitHub Actions
Inactive
bo156
approved these changes
Sep 2, 2024
qdelettre
pushed a commit
to qdelettre/checkov
that referenced
this pull request
Sep 2, 2024
) * add support for windows 10 for aiohttp * revert unrelevant changes * revert unrelevant changes * clean * clean --------- Co-authored-by: adam varsano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add support for windows 10 for aiohttp, it's throwing an error:
RuntimeError: aiodns needs a SelectorEventLoop on Windows.Checklist: