Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Security group attached to an Elastic DocumentDB cluster is not recognized by check CKV2_AWS_5 #6687

Conversation

bhean
Copy link
Contributor

@bhean bhean commented Aug 27, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Include Elastic DocumentDB as a valid associated resource for an aws_security_group for graph check CKV2_AWS_5

Fixes #6686

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@bhean bhean force-pushed the fix/issue-6686-unrecognised-sg-in-docdbelastic branch from 85dc7fc to 9de662c Compare August 27, 2024 14:06
Copy link
Contributor

@bo156 bo156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!
please see my comment

@bhean
Copy link
Contributor Author

bhean commented Aug 29, 2024

thanks for the contribution! please see my comment

Hi!! If I'm not wrong, the failing test is defined in line 833 of this file.
This is a check for an specific thing (a security group attached to nothing) so we only need a passing test for each passing condition, but only one failing test (for a security group attached to nothing), is that correct?
So, IMHO the pull-request is complete... but this is my first contribution here, so if I'm wrong about that, please don't hesitate to pointing me in the right direction...

@itai1357
Copy link
Contributor

Hi @bhean.
you seems to be right. will check it with engineers with knowledge in the area and will return an answer =]

@itai1357 itai1357 merged commit 5ccbfa3 into bridgecrewio:main Sep 19, 2024
37 of 38 checks passed
@bhean bhean deleted the fix/issue-6686-unrecognised-sg-in-docdbelastic branch September 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV2_AWS_5: Security group attached to an Elastic DocumentDB cluster is not recognized
3 participants