Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): AzureContainerInstanceEnvVarSecureValueType #6625

Closed
wants to merge 2 commits into from

Conversation

pninib
Copy link

@pninib pninib commented Jul 30, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

adds a AzureContainerInstanceEnvVarSecureValueType

Description

The scan_resource_conf function checks if container environment variables in an Azure object are set to secure only (ie, no "value" key is used). If it finds environment variables containing the key "value", the test fails; Otherwise, the test passes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@ChanochShayner ChanochShayner changed the title feat(arm): AzureContainerInstanceEnvVarSecureValueType feat(arm): AzureContainerInstanceEnvVarSecureValueType Jul 31, 2024
@ChanochShayner
Copy link
Contributor

Same as here -
#6341 (comment)

@ChanochShayner
Copy link
Contributor

Closing, feel free to reopen and tofix the failing UTs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants