-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arm): NSGRuleUDPAccessRestricted #6616
Open
esterKoren
wants to merge
9
commits into
bridgecrewio:main
Choose a base branch
from
esterKoren:NSGRuleUDPAccessRestricted
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
de3ac7b
fix
esterKoren cb038ea
Update NSGRuleUDPAccessRestricted.py
esterKoren 8b15cc4
Update NSGRuleUDPAccessRestricted.py
esterKoren ef8dc61
Merge branch 'main' into NSGRuleUDPAccessRestricted
itai1357 9f4a101
Merge branch 'main' into NSGRuleUDPAccessRestricted
itai1357 b5698fd
update
esterKoren e1e4ce6
Merge remote-tracking branch 'origin/NSGRuleUDPAccessRestricted' into…
esterKoren f9e8db1
Merge branch 'main' into NSGRuleUDPAccessRestricted
esterKoren 185d656
Update NSGRuleUDPAccessRestricted.py
esterKoren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from checkov.common.models.enums import CheckCategories, CheckResult | ||
| from checkov.arm.checks.resource.NSGRulePortAccessRestricted import INTERNET_ADDRESSES | ||
| from checkov.arm.base_resource_check import BaseResourceCheck | ||
| from typing import List, Dict, Union, Any | ||
|
|
||
|
|
||
| class NSGRuleUDPAccessRestricted(BaseResourceCheck): | ||
| def __init__(self) -> None: | ||
| name = "Ensure that UDP Services are restricted from the Internet " | ||
| id = "CKV_AZURE_77" | ||
| supported_resources = ['Microsoft.Network/networkSecurityGroups', | ||
| 'Microsoft.Network/networkSecurityGroups/securityRules'] | ||
| categories = [CheckCategories.NETWORKING] | ||
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
||
| def scan_resource_conf(self, conf: Dict[str, Union[str, Dict[str, List[Dict[str, str] | Any]]]]) -> CheckResult: | ||
| rule_confs = [conf.get("properties", {})] | ||
| evaluated_key_prefix = '' | ||
| if isinstance(rule_confs[0], dict) and 'securityRules' in rule_confs[0]: | ||
| rule_confs = [rule_confs[0]['securityRules'][0]["properties"]] | ||
| self.evaluated_keys = ['securityRules'] | ||
| evaluated_key_prefix = 'securityRules/' | ||
| for rule_conf in rule_confs: | ||
| if isinstance(rule_conf, dict): | ||
| protocol = rule_conf.get('protocol') | ||
| direction = rule_conf.get('direction') | ||
| access = rule_conf.get('access') | ||
| source_address_prefix = rule_conf.get('sourceAddressPrefix') | ||
| if isinstance(protocol, str) and protocol.lower() == 'udp' \ | ||
| and isinstance(direction, str) and direction.lower() == 'inbound' \ | ||
| and isinstance(access, str) and access.lower() == 'allow' \ | ||
| and isinstance(source_address_prefix, str) \ | ||
| and source_address_prefix.lower() in INTERNET_ADDRESSES: | ||
| evaluated_key_prefix = f'{evaluated_key_prefix}[{rule_confs.index(rule_conf)}]/' if \ | ||
| evaluated_key_prefix else '' | ||
| self.evaluated_keys = [f'{evaluated_key_prefix}protocol', | ||
| f'{evaluated_key_prefix}direction', | ||
| f'{evaluated_key_prefix}access', | ||
| f'{evaluated_key_prefix}sourceAddressPrefix'] | ||
| return CheckResult.FAILED | ||
| return CheckResult.PASSED | ||
| return CheckResult.UNKNOWN | ||
| return CheckResult.PASSED | ||
|
|
||
|
|
||
| check = NSGRuleUDPAccessRestricted() | ||
33 changes: 33 additions & 0 deletions
33
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/fail.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "fail", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "fail", | ||
| "properties": { | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "*", | ||
| "destinationAddressPrefix": "*", | ||
| "access": "Allow", | ||
| "priority": 100, | ||
| "direction": "Inbound" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
|
|
||
| ] | ||
| } |
33 changes: 33 additions & 0 deletions
33
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/fail2.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "fail2", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "fail2", | ||
| "properties": { | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "any", | ||
| "destinationAddressPrefix": "*", | ||
| "access": "Allow", | ||
| "priority": 100, | ||
| "direction": "Inbound" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
|
|
||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/fail3.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "fail3", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Allow", | ||
| "direction": "Inbound", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "<nw>/0", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/fail4.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "fail4", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Allow", | ||
| "direction": "Inbound", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "/0", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/fail5.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "fail5", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Allow", | ||
| "direction": "Inbound", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "Internet", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/pass.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "pass", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Deny", | ||
| "direction": "Inbound", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "*", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/pass2.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "pass2", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Allow", | ||
| "direction": "Outbound", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "*", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/pass3.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "pass3", | ||
| "location": "[parameters('region')]", | ||
| "properties": { | ||
| "securityRules": [ | ||
| { | ||
| "name": "test123", | ||
| "properties": { | ||
| "priority": 100, | ||
| "access": "Allow", | ||
| "direction": "Inbound", | ||
| "protocol": "Tcp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "*", | ||
| "destinationAddressPrefix": "*" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "tags": { | ||
| "environment": "Production" | ||
| } | ||
| } | ||
| ] | ||
| } |
33 changes: 33 additions & 0 deletions
33
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/ruleFail.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups/securityRules", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "ruleFail", | ||
| "location": "[resourceGroup().location]", | ||
| "properties": { | ||
| "priority": 100, | ||
| "direction": "Inbound", | ||
| "access": "Allow", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "*", | ||
| "destinationAddressPrefix": "*" | ||
| }, | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Network/networkSecurityGroups', parameters('networkSecurityGroupName'))]" | ||
| ] | ||
| } | ||
| ], | ||
| "parameters": { | ||
| "networkSecurityGroupName": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "The name of the Network Security Group." | ||
| } | ||
| } | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
tests/arm/checks/resource/example_NSGRuleUDPAccessRestricted/ruleFail2.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Network/networkSecurityGroups/securityRules", | ||
| "apiVersion": "2020-11-01", | ||
| "name": "ruleFail2", | ||
| "location": "[resourceGroup().location]", | ||
| "properties": { | ||
| "priority": 100, | ||
| "direction": "Inbound", | ||
| "access": "Allow", | ||
| "protocol": "Udp", | ||
| "sourcePortRange": "*", | ||
| "destinationPortRange": "*", | ||
| "sourceAddressPrefix": "any", | ||
| "destinationAddressPrefix": "*" | ||
| }, | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Network/networkSecurityGroups', parameters('networkSecurityGroupName'))]" | ||
| ] | ||
| } | ||
| ], | ||
| "parameters": { | ||
| "networkSecurityGroupName": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "The name of the Network Security Group." | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is failing the dogfood-tests