Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform_plan): Fix parsing other types of provisioners #6606

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

tsmithv11
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

The parser was causing errors for provisioners that weren't local-exec. This fixes: #5622 (comment)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@junhu73
Copy link

junhu73 commented Jul 26, 2024

Thanks. Just FYI, don't think it is due to your feature. The same terraform plan file trigged this bug on ubuntu, but didn't get triggered on Mac OS (seems on the Mac, it only processes one of local-exec provisioners resources, it didn't process all the local-exec resources and remote-exec/file provisioners).

@tsmithv11 tsmithv11 merged commit fc99037 into main Jul 29, 2024
41 checks passed
@tsmithv11 tsmithv11 deleted the fix-provisioner-jul-24 branch July 29, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants