Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform(general): handle multiple values for the same metadata filter #6604

Merged
merged 3 commits into from
Jul 25, 2024
Merged

platform(general): handle multiple values for the same metadata filter #6604

merged 3 commits into from
Jul 25, 2024

Conversation

mikeurbanski1
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Allows multiple values for the same metadata filter attribute (e.g., policy.label) and passes them to the Prisma APIs.

Example:

--policy-metadata-filter policy.label=label1,policy.label=label2

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

kartikp10
kartikp10 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@kartikp10 kartikp10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

@mikeurbanski1 mikeurbanski1 merged commit 93db38b into main Jul 25, 2024
37 of 38 checks passed
@mikeurbanski1 mikeurbanski1 deleted the add-multi-value-policy-metadata branch July 25, 2024 16:20
boring-repos bot pushed a commit to harryzcy/checkov that referenced this pull request Jul 26, 2024
@mikeurbanski1 @actions-user
platform(general): handle multiple values for the same metadata filter (
6ad3b69 
bridgecrewio#6604)

* handle multiple values for the same metadata filter

* update policy metadata arg help text

* add missing return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikp10 kartikp10 kartikp10 approved these changes

@tsmithv11 tsmithv11 tsmithv11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeurbanski1 @kartikp10 @tsmithv11