feat(arm): ARM VnetSingleDNSServer #6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
force-pushed
the
v_net_single_dns_server
branch
from
d7433f2
to
f39fb64
Compare
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
force-pushed
the
v_net_single_dns_server
branch
from
7095977
to
07d983c
Compare
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
changed the title
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
…net_single_dns_server
RachelBorzi
temporarily deployed
to
scan-security
GitHub Actions
Inactive
ChanochShayner
approved these changes
Jun 11, 2024
tsmithv11
requested changes
Jun 27, 2024
There was a problem hiding this comment.
This is a valid check (and we should update the TF policy similarly), but the corresponding TF policy is for azurerm_virtual_network which is Microsoft.Network/virtualNetworks. Can you add to this check support for this resource? dnsServers is under properties -> dhcpOptions.
RachelBorzi
had a problem deploying
to
scan-security
GitHub Actions
Failure
tongyiming
pushed a commit
to tongyiming/checkov
that referenced
this pull request
Jul 22, 2024
* feat(arm) vnet_single_dns_server * feat(arm) vnet_single_dns_server * feat(arm) the right file * revert changes on this file, not finished with it yet * revert changes on this file * feat(arm) fix file * feat(arm) fix file * add supported resources --------- Co-authored-by: gruebel <[email protected]> Co-authored-by: Rachel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Added new policy for -
VnetSingleDNSServer - CKV_AZURE_182
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
policy: Ensure that VNET has at least 2 connected DNS Endpoints
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: