-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arm): add CKV_AZURE_75 data explorer double encryption enabled convert policy to arm #6247
Merged
ChanochShayner
merged 27 commits into
bridgecrewio:main
from
goldyBH:mariaDBConvertToARM
Jul 15, 2024
Merged
feat(arm): add CKV_AZURE_75 data explorer double encryption enabled convert policy to arm #6247
ChanochShayner
merged 27 commits into
bridgecrewio:main
from
goldyBH:mariaDBConvertToARM
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldyBH
changed the title
Maria db convert to arm
feat(arm): add data explorer double encryption enabled convert policy to arm
May 5, 2024
ChanochShayner
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please fix the failing jobs (Mypy, etc..)
name = "Ensure that Azure Data Explorer uses double encryption" | ||
id = "CKV_AZURE_75" | ||
supported_resources = ("Microsoft.Compute/disks",) | ||
categories = [CheckCategories.ENCRYPTION] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use tuple instead of a list
@goldyBH Any reason why you closed this PR? |
goldyBH
changed the title
feat(arm): add data explorer double encryption enabled convert policy to arm
feat(arm): add CKV_AZURE_75 data explorer double encryption enabled convert policy to arm
Jun 9, 2024
ChanochShayner
had a problem deploying
to
scan-security
July 4, 2024 08:04
— with
GitHub Actions
Failure
checkov/arm/checks/resource/AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
checkov/arm/checks/resource/AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
checkov/arm/checks/resource/AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
tests/arm/checks/resource/example_AzureDataExplorerDoubleEncryptionEnabled/fail.json
Outdated
Show resolved
Hide resolved
tests/arm/checks/resource/example_AzureDataExplorerDoubleEncryptionEnabled/pass.json
Outdated
Show resolved
Hide resolved
ChanochShayner
had a problem deploying
to
scan-security
July 15, 2024 08:11
— with
GitHub Actions
Failure
tests/arm/checks/resource/example_AzureDataExplorerDoubleEncryptionEnabled/fail.json
Outdated
Show resolved
Hide resolved
tests/arm/checks/resource/example_AzureDataExplorerDoubleEncryptionEnabled/pass.json
Outdated
Show resolved
Hide resolved
tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
ChanochShayner
temporarily deployed
to
scan-security
July 15, 2024 08:18
— with
GitHub Actions
Inactive
tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py
Outdated
Show resolved
Hide resolved
ChanochShayner
had a problem deploying
to
scan-security
July 15, 2024 08:30
— with
GitHub Actions
Failure
ChanochShayner
temporarily deployed
to
scan-security
July 15, 2024 08:30
— with
GitHub Actions
Inactive
SteveVaknin
approved these changes
Jul 15, 2024
shoshiGit
pushed a commit
to shoshiGit/shoshi-wolpe-checkov
that referenced
this pull request
Jul 15, 2024
…onvert policy to arm (bridgecrewio#6247) * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * remove files * remove files * remove files * remove files * remove files * remove files * remove files * faild * faild * faild * faild * Update AzureDataExplorerDoubleEncryptionEnabled.py * Update AzureDataExplorerDoubleEncryptionEnabled.py * Apply suggestions from code review * Apply suggestions from code review * Update tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py --------- Co-authored-by: gruebel <[email protected]> Co-authored-by: ChanochShayner <[email protected]>
shoshiGit
pushed a commit
to shoshiGit/shoshi-wolpe-checkov
that referenced
this pull request
Jul 15, 2024
…onvert policy to arm (bridgecrewio#6247) * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * chore: update release notes * remove files * remove files * remove files * remove files * remove files * remove files * remove files * faild * faild * faild * faild * Update AzureDataExplorerDoubleEncryptionEnabled.py * Update AzureDataExplorerDoubleEncryptionEnabled.py * Apply suggestions from code review * Apply suggestions from code review * Update tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py --------- Co-authored-by: gruebel <[email protected]> Co-authored-by: ChanochShayner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We converted the check AzureDataExplorerDoubleEncryptionEnabled from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language
Ensure that Azure Data Explorer uses double encryption
Allowed prefixs:
"