Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): add CKV_AZURE_75 data explorer double encryption enabled convert policy to arm #6247

Merged
merged 27 commits into from
Jul 15, 2024

Conversation

goldyBH
Copy link
Contributor

@goldyBH goldyBH commented May 5, 2024

We converted the check AzureDataExplorerDoubleEncryptionEnabled from TERRAFORM language to the ARM language so that it also works on resources that are defined in the ARM language

Ensure that Azure Data Explorer uses double encryption
Allowed prefixs:

feat(arm): add azure data explorer double encryption enabled convert policy to arm

"

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@goldyBH goldyBH changed the title Maria db convert to arm feat(arm): add data explorer double encryption enabled convert policy to arm May 5, 2024
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please fix the failing jobs (Mypy, etc..)

name = "Ensure that Azure Data Explorer uses double encryption"
id = "CKV_AZURE_75"
supported_resources = ("Microsoft.Compute/disks",)
categories = [CheckCategories.ENCRYPTION]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tuple instead of a list

@ChanochShayner
Copy link
Contributor

@goldyBH Any reason why you closed this PR?

@goldyBH goldyBH reopened this May 6, 2024
@goldyBH goldyBH closed this by deleting the head repository May 6, 2024
@goldyBH goldyBH reopened this May 6, 2024
@goldyBH goldyBH changed the title feat(arm): add data explorer double encryption enabled convert policy to arm feat(arm): add CKV_AZURE_75 data explorer double encryption enabled convert policy to arm Jun 9, 2024
@ChanochShayner ChanochShayner merged commit 0efe05d into bridgecrewio:main Jul 15, 2024
40 of 41 checks passed
shoshiGit pushed a commit to shoshiGit/shoshi-wolpe-checkov that referenced this pull request Jul 15, 2024
…onvert policy to arm (bridgecrewio#6247)

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* remove files

* remove files

* remove files

* remove files

* remove files

* remove files

* remove files

* faild

* faild

* faild

* faild

* Update AzureDataExplorerDoubleEncryptionEnabled.py

* Update AzureDataExplorerDoubleEncryptionEnabled.py

* Apply suggestions from code review

* Apply suggestions from code review

* Update tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py

---------

Co-authored-by: gruebel <[email protected]>
Co-authored-by: ChanochShayner <[email protected]>
shoshiGit pushed a commit to shoshiGit/shoshi-wolpe-checkov that referenced this pull request Jul 15, 2024
…onvert policy to arm (bridgecrewio#6247)

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* chore: update release notes

* remove files

* remove files

* remove files

* remove files

* remove files

* remove files

* remove files

* faild

* faild

* faild

* faild

* Update AzureDataExplorerDoubleEncryptionEnabled.py

* Update AzureDataExplorerDoubleEncryptionEnabled.py

* Apply suggestions from code review

* Apply suggestions from code review

* Update tests/arm/checks/resource/test_AzureDataExplorerDoubleEncryptionEnabled.py

---------

Co-authored-by: gruebel <[email protected]>
Co-authored-by: ChanochShayner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants