Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Ensure App Service Environment is zone redundant #5662

Merged
merged 4 commits into from
Nov 5, 2023
Merged

feat(terraform): Ensure App Service Environment is zone redundant #5662

merged 4 commits into from
Nov 5, 2023

Conversation

tdefise
Copy link
Contributor

@tdefise tdefise commented Oct 18, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes #5661

Description

Applications deployed on a zonal ILB (Internally Load Balanced) ASE (App Service Environment) will continue to run and serve traffic on that ASE even if other zones in the same region suffer an outage. It is possible that non-runtime behaviors, including; application service plan scaling, application creation, application configuration, and application publishing may still be impacted from an outage in other availability zones.
Source : https://learn.microsoft.com/en-us/azure/app-service/environment/zone-redundancy

Fix

Enable Zone Redundancy

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tdefise tdefise temporarily deployed to scan-security October 18, 2023 13:02 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@gruebel gruebel merged commit 8bee5c6 into bridgecrewio:main Nov 5, 2023
37 checks passed
andyloughran pushed a commit to andyloughran/checkov that referenced this pull request Nov 5, 2023
…idgecrewio#5662)

* Created check CKV_AZURE_228

* Fixed issues with the unit test

* adjust check ID

---------

Co-authored-by: Thomas Defise <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure App Service Environment - Ensure App Service Environment is zone redundant
3 participants