Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve various Terraform checks #5658

Merged
merged 2 commits into from
Oct 18, 2023
Merged

chore: improve various Terraform checks #5658

merged 2 commits into from
Oct 18, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 17, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • the checks are still passing and failing the same resources, but are simpler

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security October 17, 2023 20:41 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 17, 2023 21:00 — with GitHub Actions Inactive
SteveVaknin
SteveVaknin approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Left a question

checkov/terraform/checks/resource/aws/EKSPublicAccessCIDR.py Show resolved Hide resolved
@gruebel gruebel merged commit 024b2b2 into bridgecrewio:main Oct 18, 2023
29 checks passed
@gruebel gruebel deleted the improve-checks branch October 18, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanochShayner ChanochShayner ChanochShayner approved these changes

@SteveVaknin SteveVaknin SteveVaknin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruebel @ChanochShayner @SteveVaknin