fix(terraform): update CKV_AWS_339 valid EKS versions #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EKS 1.23 ended support on 11 Oct 2023. Include 1.28 as valid version.
aqujesus
had a problem deploying
to
scan-security
GitHub Actions
Failure
gruebel
suggested changes
Oct 16, 2023
| @@ -24,7 +24,7 @@ def get_inspected_key(self) -> str: | |||
| return "version" | |||
|
|
|||
| def get_expected_values(self) -> list[Any]: | |||
| return ["1.23", "1.24", "1.25", "1.26", "1.27"] | |||
| return ["1.24", "1.25", "1.26", "1.27", "1.28"] | |||
There was a problem hiding this comment.
Suggested change
| return ["1.24", "1.25", "1.26", "1.27", "1.28"] | |
| return ["1.23", "1.24", "1.25", "1.26", "1.27", "1.28"] |
I'm fine with adding 1.28, but not about removing 1.23, because AWS offers extended support for an additional 12 months.
EKS 1.23 extended support works as 11 Oct 2024. Include 1.28 as valid version. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. fix(terraform): update CKV_AWS_339 valid EKS versions Description The change in valid versions, as now 1.24 is the lowest supported version and 1.28 the newest available. Fix Update EKS version to a valid version Checklist: My code follows the style guidelines of this project I have performed a self-review of my own code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation I have added tests that prove my feature, policy, or fix is effective and works New and existing tests pass locally with my changes Any dependent changes have been merged and published in downstream modules
aqujesus
had a problem deploying
to
scan-security
GitHub Actions
Failure
aqujesus
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Update EKSPlatformVersion.py EKS 1.23 ended support on 11 Oct 2023. Include 1.28 as valid version. * fix(terraform): update CKV_AWS_339 valid EKS versions EKS 1.23 extended support works as 11 Oct 2024. Include 1.28 as valid version. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. fix(terraform): update CKV_AWS_339 valid EKS versions Description The change in valid versions, as now 1.24 is the lowest supported version and 1.28 the newest available. Fix Update EKS version to a valid version Checklist: My code follows the style guidelines of this project I have performed a self-review of my own code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation I have added tests that prove my feature, policy, or fix is effective and works New and existing tests pass locally with my changes Any dependent changes have been merged and published in downstream modules * add missing space --------- Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EKS 1.23 ended support on 11 Oct 2023.
Include 1.28 as valid version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The change in valid versions, as now 1.24 is the lowest supported version and 1.28 the newest available.
Fix
Update EKS version to a valid version
Checklist: