Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Added a check to make sure dynamic "blocks" are of the expected type #5642

Merged
merged 4 commits into from
Oct 18, 2023
Merged

fix(terraform): Added a check to make sure dynamic "blocks" are of the expected type #5642

merged 4 commits into from
Oct 18, 2023

Conversation

tf-rob-w
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Using some providers, dynamic can just be a scalar field and not an HCL block, which causes a TypeError.

Fixes #5641

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tf-rob-w tf-rob-w temporarily deployed to scan-security October 13, 2023 12:47 — with GitHub Actions Inactive
@tf-rob-w tf-rob-w temporarily deployed to scan-security October 18, 2023 09:04 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution 🏆

ChanochShayner
ChanochShayner approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@gruebel gruebel merged commit f841619 into bridgecrewio:main Oct 18, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources that contain scalar fields named "dynamic" not parsing properly
3 participants
@tf-rob-w @gruebel @ChanochShayner