Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): Remove code upload for on-prem integrations #5624

Merged
merged 8 commits into from
Oct 12, 2023
Merged

feat(general): Remove code upload for on-prem integrations #5624

merged 8 commits into from
Oct 12, 2023

Conversation

kartikp10
Copy link
Contributor

@kartikp10 kartikp10 commented Oct 6, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Based on the runConfig, determines if an integration is on-premises.
  • Does not persist any source files for on-premises integrations.
  • Removes code_blocks from the scan reports.
  • Disables sca image and package runners.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mikeurbanski1
mikeurbanski1 reviewed Oct 6, 2023
View reviewed changes
checkov/main.py Outdated Show resolved Hide resolved
@kartikp10 kartikp10 marked this pull request as ready for review October 11, 2023 12:02
@kartikp10 kartikp10 temporarily deployed to scan-security October 11, 2023 12:02 — with GitHub Actions Inactive
gruebel
gruebel reviewed Oct 11, 2023
View reviewed changes
checkov/main.py Outdated Show resolved Hide resolved
checkov/main.py Outdated Show resolved Hide resolved
@gruebel gruebel temporarily deployed to scan-security October 11, 2023 14:32 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@kartikp10 kartikp10 merged commit 761960b into main Oct 12, 2023
29 checks passed
@kartikp10 kartikp10 deleted the skip-code-upload branch October 12, 2023 13:22
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Oct 12, 2023
@kartikp10 @gruebel @actions-user
feat(general): Remove code upload for on-prem integrations (bridgecre…
7ad207a 
…wio#5624)

* skip code upload for on-prem and cleanup reports

* fix flag

* default to false

* print warning

* linting and test fix

* address comments

* fix typing

---------

Co-authored-by: gruebel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbanski1 mikeurbanski1 mikeurbanski1 approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikp10 @mikeurbanski1 @gruebel