Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Adding missing null checks #5589

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix(terraform): Adding missing null checks #5589

merged 1 commit into from
Sep 26, 2023

Conversation

ArjunMenon-bit
Copy link
Contributor

@ArjunMenon-bit ArjunMenon-bit commented Sep 23, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Adding Null checks to run terraform plan using an external json file. Bug reported in issue: #4473

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ArjunMenon-bit ArjunMenon-bit temporarily deployed to scan-security September 23, 2023 18:27 — with GitHub Actions Inactive
@ArjunMenon-bit
Copy link
Contributor Author

ArjunMenon-bit commented Sep 24, 2023 •
edited
Loading

@gruebel
I am a new contributor to this project. Whom should I reach out to get approvals on this PR.

@gruebel gruebel linked an issue Sep 24, 2023 that may be closed by this pull request
Checkov crashes due to missing null checks in CKV_K8S_49 #4473
Closed
gruebel
gruebel approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution 🏆

Typically it will be reviewed on working days 🙂

@ArjunMenon-bit
Copy link
Contributor Author

@JamesWoolfenden Could you please approve this PR if it looks good to you.

JamesWoolfenden
JamesWoolfenden approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@JamesWoolfenden JamesWoolfenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArjunMenon-bit
Copy link
Contributor Author

@gruebel are we good to merge this?

@gruebel gruebel merged commit 9225ab3 into bridgecrewio:main Sep 26, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWoolfenden JamesWoolfenden JamesWoolfenden approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkov crashes due to missing null checks in CKV_K8S_49
3 participants
@ArjunMenon-bit @JamesWoolfenden @gruebel