Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): revert creating alias mapping for javascript #5581

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

itai1357
Copy link
Contributor

This reverts commit 10797d9.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@itai1357 itai1357 merged commit d58e190 into main Sep 20, 2023
26 of 28 checks passed
@itai1357 itai1357 deleted the itai_revert branch September 20, 2023 12:43
lif2 pushed a commit to lif2/checkov that referenced this pull request Sep 20, 2023
…#5581)

Revert "feat(sca): creating alias mapping for javascript (bridgecrewio#5567)"

This reverts commit 10797d9.

Co-authored-by: ipeleg <[email protected]>
itai1357 pushed a commit that referenced this pull request Sep 20, 2023
itai1357 added a commit that referenced this pull request Sep 20, 2023
* Revert "feat(sca): revert creating alias mapping for javascript (#5581)"

This reverts commit d58e190.

* not using pydantic

* delete the typing

---------

Co-authored-by: ipeleg <[email protected]>
pull bot pushed a commit to Julian-Louis/checkov that referenced this pull request Sep 20, 2023
* Revert "feat(sca): revert creating alias mapping for javascript (bridgecrewio#5581)"

This reverts commit d58e190.

* not using pydantic

* delete the typing

---------

Co-authored-by: ipeleg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants