feat(sca): creating alias mapping for javascript #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
NoaAzoulay
reviewed
Sep 14, 2023
checkov/common/sca/reachability/javascript/javascript_alias_mapping_strategy.py
Outdated
Show resolved
Hide resolved
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
| from typing import List, Dict | ||
|
|
||
| # {<package_name>: {"packageAliases": [<alias_1> ,..... , <alias_n>]}} | ||
| FileParserOutput = Dict[str, Dict[str, List[str]]] |
There was a problem hiding this comment.
Let's create stricter types for the entire mapping object (can leverage pydantic for that)
Since we will pass this object to sast-core we need to have a clear view of the "contract"
There was a problem hiding this comment.
agreed. let's talk !
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
added 2 commits
September 19, 2023 14:17
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
itai1357
had a problem deploying
to
scan-security
GitHub Actions
Failure
Eliran-Turgeman
approved these changes
Sep 19, 2023
lif2
pushed a commit
to lif2/checkov
that referenced
this pull request
Sep 20, 2023
* add javascript_alias_mapping_strategy * test, failure handling * fix flake8 * rwemoving redudnat prints * fix mypy * creating the utils file * using the new format * using the new format * fix tests * fix tests * fix tests * fix tests * remove file * using pydantic * fix tests * fix tests * fix tests * fix tests * add --------- Co-authored-by: ipeleg <[email protected]>
itai1357
pushed a commit
that referenced
this pull request
Sep 20, 2023
This reverts commit 10797d9.
itai1357
added a commit
that referenced
this pull request
Sep 20, 2023
Revert "feat(sca): creating alias mapping for javascript (#5567)" This reverts commit 10797d9. Co-authored-by: ipeleg <[email protected]>
lif2
pushed a commit
to lif2/checkov
that referenced
this pull request
Sep 20, 2023
…#5581) Revert "feat(sca): creating alias mapping for javascript (bridgecrewio#5567)" This reverts commit 10797d9. Co-authored-by: ipeleg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
creating alias mapping for javascript
Checklist: