Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(general): Add redefine to pr tests in discover mode #5417

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

GerevSec
Copy link
Contributor

@GerevSec GerevSec commented Aug 6, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Implementing the first step of Redefine's optimization platform in checkov, after speaking with @gruebel and @taloferregev.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@GerevSec GerevSec changed the title Add redefine to pr tests in discover mode chore: Add redefine to pr tests in discover mode Aug 7, 2023
@GerevSec GerevSec changed the title chore: Add redefine to pr tests in discover mode chore(general): Add redefine to pr tests in discover mode Aug 7, 2023
@gruebel
Copy link
Contributor

gruebel commented Aug 10, 2023

@GerevSec you can ignore the danger-check it has the same problem as your PR, no access to secrets for outside contributors.

@GerevSec GerevSec temporarily deployed to scan-security September 3, 2023 11:56 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@GerevSec GerevSec temporarily deployed to scan-security September 18, 2023 10:07 — with GitHub Actions Inactive
@gruebel gruebel merged commit 8f73e5d into bridgecrewio:main Sep 19, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants