Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add python 3.12 build #5388

Merged
merged 16 commits into from
Nov 21, 2023
Merged

chore: add python 3.12 build #5388

merged 16 commits into from
Nov 21, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jul 30, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • updated all workflow files, there is a special treatment of 3.12 for updating the lock file to get a newer numpy version which is supports 3.12, but not 3.8 😅
  • replace freezegun with time-machine
  • removed mock dependency, because the built-in under unittest supports all we need
    Fixes ERROR: Failed building wheel for aiohttp #5712

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security July 30, 2023 16:40 — with GitHub Actions Inactive
@gruebel
Merge remote-tracking branch 'origin/main' into add-python-312
3ac6425 
# Conflicts:
#	.github/workflows/pr-test.yml
@gruebel gruebel temporarily deployed to scan-security October 8, 2023 22:51 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security October 9, 2023 16:51 — with GitHub Actions Inactive
@Saarett
Copy link
Contributor

Saarett commented Nov 14, 2023

@gruebel Would you like me to take it from here?

@gruebel
Copy link
Contributor Author

gruebel commented Nov 15, 2023

no need, I'm just waiting till aiohttp version 3.9.0 is released 😄

@gruebel
Merge remote-tracking branch 'origin/main' into add-python-312
8ddbf4f 
# Conflicts:
#	Pipfile.lock
#	tests/sca_package_2/test_runner_dependency_tree.py
@gruebel
update aiohttp to 3.9.0
f8cf364
@gruebel gruebel marked this pull request as ready for review November 18, 2023 22:32
Saarett
Saarett approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 1️⃣ 2️⃣

@gruebel gruebel merged commit 414e36c into bridgecrewio:main Nov 21, 2023
41 checks passed
@gruebel gruebel deleted the add-python-312 branch November 21, 2023 13:17
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Nov 22, 2023
@gruebel @actions-user
chore: add python 3.12 build (bridgecrewio#5388)
c34c7fe 
* add python 3.12 build

* update deps

* upgrade aiohttp

* first install/update setuptools

* make sure numpy is isntalled with latest version

* skip lock file

* fix depreaction and replace freezegun package

* set shell as bash

* update aiohttp to 3.9.0

* also install wheel

* update aioresponses

* fix abstract test

* add 3.12 classifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saarett Saarett Saarett approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: Failed building wheel for aiohttp
3 participants
@gruebel @Saarett @lirshindalman