feat(general): enrich terraform definitions context key #5350

lirshindalman · 2023-07-17T15:35:58Z

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

in terraform definitions_context change the key to all TFDefinitionKey objects instead of only the file_path

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my feature, policy, or fix is effective and works
New and existing tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

checkov/terraform/context_parsers/base_parser.py

checkov/terraform/context_parsers/registry.py

checkov/terraform/graph_builder/graph_components/blocks.py

checkov/terraform/context_parsers/registry.py

bo156

nice work!

checkov/terraform/context_parsers/registry.py

checkov/common/util/parser_utils.py

checkov/terraform/runner.py

…#5350) * use tf_definition_key in definitions_context file * use tf_definition_key in definitions_context file * use tf_definition_key in definitions_context file * use tf_definition_key in definitions_context file * use tf_definition_key in definitions_context file * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * str | TFDefinitionKey * . * . * . * .

lirshindalman added 2 commits July 17, 2023 17:20

use tf_definition_key in definitions_context file

e4bc204

use tf_definition_key in definitions_context file

6f386e9

lirshindalman had a problem deploying to scan-security July 17, 2023 15:36 — with GitHub Actions Failure

lirshindalman changed the title ~~Enrich definitions context key~~ feat(general): enrich terrafoem definitions context key Jul 17, 2023

lirshindalman changed the title ~~feat(general): enrich terrafoem definitions context key~~ feat(general): enrich terraform definitions context key Jul 17, 2023

use tf_definition_key in definitions_context file

8a7d264

lirshindalman had a problem deploying to scan-security July 17, 2023 15:40 — with GitHub Actions Failure

use tf_definition_key in definitions_context file

b0e8df2

lirshindalman had a problem deploying to scan-security July 17, 2023 15:51 — with GitHub Actions Failure

use tf_definition_key in definitions_context file

133fae5

lirshindalman had a problem deploying to scan-security July 18, 2023 07:01 — with GitHub Actions Failure

Merge branch 'main' into enrich_definitions_context_key

3dc727c

lirshindalman had a problem deploying to scan-security July 18, 2023 07:04 — with GitHub Actions Failure

.

c7de3ab

lirshindalman had a problem deploying to scan-security July 19, 2023 12:35 — with GitHub Actions Failure

lirshindalman added 2 commits July 19, 2023 15:51

.

6769269

.

f5aa95e

lirshindalman had a problem deploying to scan-security July 19, 2023 12:54 — with GitHub Actions Failure

.

bd6b44c

lirshindalman had a problem deploying to scan-security July 19, 2023 13:48 — with GitHub Actions Failure

.

1d28ddc

lirshindalman had a problem deploying to scan-security July 19, 2023 13:50 — with GitHub Actions Failure

.

6adca0b

lirshindalman had a problem deploying to scan-security July 19, 2023 13:53 — with GitHub Actions Failure

.

0ca8832

lirshindalman had a problem deploying to scan-security July 19, 2023 15:08 — with GitHub Actions Failure

.

c2771ce

lirshindalman had a problem deploying to scan-security July 19, 2023 15:32 — with GitHub Actions Failure

.

18a5fab

lirshindalman had a problem deploying to scan-security July 19, 2023 15:33 — with GitHub Actions Failure

lirshindalman had a problem deploying to scan-security July 20, 2023 16:07 — with GitHub Actions Failure

.

a252d1e

lirshindalman had a problem deploying to scan-security July 20, 2023 16:14 — with GitHub Actions Failure

.

88f58ca

lirshindalman had a problem deploying to scan-security July 20, 2023 16:14 — with GitHub Actions Failure

Merge branch 'main' into enrich_definitions_context_key

f1c2497

lirshindalman temporarily deployed to scan-security July 23, 2023 06:45 — with GitHub Actions Inactive

lirshindalman requested review from bo156, ChanochShayner and omryMen July 23, 2023 07:10

omryMen approved these changes Jul 23, 2023

View reviewed changes

bo156 reviewed Jul 23, 2023

View reviewed changes

str | TFDefinitionKey

a532f5d

lirshindalman temporarily deployed to scan-security July 23, 2023 07:58 — with GitHub Actions Inactive

bo156 approved these changes Jul 23, 2023

View reviewed changes

checkov/terraform/context_parsers/registry.py Show resolved Hide resolved

YaaraVerner reviewed Jul 23, 2023

View reviewed changes

checkov/common/util/parser_utils.py Outdated Show resolved Hide resolved

.

315492a

lirshindalman had a problem deploying to scan-security July 23, 2023 08:29 — with GitHub Actions Failure

.

7c55cfb

lirshindalman had a problem deploying to scan-security July 23, 2023 08:33 — with GitHub Actions Failure

YaaraVerner reviewed Jul 23, 2023

View reviewed changes

checkov/terraform/runner.py Show resolved Hide resolved

.

9f135ed

lirshindalman had a problem deploying to scan-security July 23, 2023 09:03 — with GitHub Actions Failure

.

5df0788

lirshindalman had a problem deploying to scan-security July 23, 2023 09:04 — with GitHub Actions Failure

.

d9f5f24

lirshindalman temporarily deployed to scan-security July 23, 2023 09:08 — with GitHub Actions Inactive

lirshindalman merged commit 74137ac into main Jul 24, 2023
32 checks passed

lirshindalman deleted the enrich_definitions_context_key branch July 24, 2023 07:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(general): enrich terraform definitions context key #5350

feat(general): enrich terraform definitions context key #5350

lirshindalman commented Jul 17, 2023 •

edited by ChanochShayner

Loading

bo156 left a comment

feat(general): enrich terraform definitions context key #5350

feat(general): enrich terraform definitions context key #5350

Conversation

lirshindalman commented Jul 17, 2023 • edited by ChanochShayner Loading

Description

New/Edited policies (Delete if not relevant)

Description

Fix

Checklist:

bo156 left a comment

Choose a reason for hiding this comment

lirshindalman commented Jul 17, 2023 •

edited by ChanochShayner

Loading