Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): properly encode non supported chars in SARIF uri field #5336

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jul 14, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • leveraging the quote() function of urllib to properly handle unsupported chars

Fixes #5331

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel marked this pull request as ready for review July 14, 2023 13:29
@gruebel gruebel temporarily deployed to scan-security July 14, 2023 13:29 — with GitHub Actions Inactive
@gruebel gruebel merged commit 3c53f3f into bridgecrewio:main Jul 16, 2023
32 checks passed
@gruebel gruebel deleted the fix-sarif-uri branch July 16, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sarif report creates invalid uri for folder with spaces
3 participants